1659692 - Pioneer toolbar icon has no tooltip

Status: VERIFIED FIXED

(Firefox :: Pioneer, defect)

Description

[Alin Ilea, Desktop Test Engineering]

Attachment: Pioneer icon has no tooltip.mp4

Affected versions:

80 RC, Nightly 81.0a1 (2020-08-18)

Tested on:

Windows 10, Ubuntu 18.04.

Steps:

1. Launch Firefox with a new profile and go to about:pioneer
2. Click Get Started button and Accept and Join Pioneer.
3. Hover the mouse cursor over the Pioneer icon from the toolbar.

Actual result:

The Pioneer icon displayed in the toolbar after enrolling in Pioneer has no tooltip when hovering the mouse cursor over it.

Expected result:

The Pioneer icon displayed in the toolbar should have tooltip when hover the mouse over it.

Severity suggestion: S4

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:rhelmer, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[Robert Helmer [:rhelmer]]

Attachment: Bug 1659692 - add tooltip to Ion icon

Comment 3

[Robert Helmer [:rhelmer]]

Comment on attachment 9183325 [details]
Bug 1659692 - add tooltip to Ion icon

Beta/Release Uplift Approval Request

• User impact if declined: Ion toolbar icon will not have a tooltip describing what it is
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce: Hover over Ion icon and observe tooltip or lack thereof
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This adds a non-localized string directly into the tooltip XUL
• String changes made/needed: No localization needed so text is added directly

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/498754ea0a37
add tooltip to Ion icon r=maxxcrawford,flod

Comment 5

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/498754ea0a37

Comment 6

[Alin Ilea, Desktop Test Engineering]

Verified - Fixed in latest Nightly 84.0a1 (build id: 20201025214116) using Windows 10 and Ubuntu 18.04. "Ion" tooltip is displayed when hovering over the Ion icon.

Comment 7

[Julien Cristau [:jcristau]]

Comment on attachment 9183325 [details]
Bug 1659692 - add tooltip to Ion icon

S4, not new, this looks like it can ride to 83 or 84.

Comment 8

[Pascal Chevrel:pascalc]

Comment on attachment 9183325 [details]
Bug 1659692 - add tooltip to Ion icon

Polish and not risky, uplift approved for 83 beta 5, thanks.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/625df6dbdf8a

Comment 10

[Alin Ilea, Desktop Test Engineering]

Verified - Fixed in latest Beta 83.0b5 (build id: 20201027175448). "Ion" tooltip is displayed when hovering over the Ion toolbar icon.