1659730 - 360 Browser is not visible in the bookmarks "Import Wizard" list

Status: VERIFIED FIXED

(Firefox :: Migration, defect, P1)

Description

[Peter Magyari (Desktop QA)]

Attachment: 360Browser-Cannot-Import_Directly.jpg

Precondition
Make sure you have 360 Browser installed

Steps to reproduce

1. Open Firefox
2. Open the Bookmarks library by pressing "Ctrl+Shift+B"
3. Press the Import/Export Arrows -> Import Data from another browsers... button

Actual Results
360 Browser isn't listed

Expected Results
360 Browser is listed

Note
You can import bookmarks via .HTML file but those are not added directly onto the Bookmarks Toolbar

Comment 1

[Hector Zhao [:hectorz]]

Hi :MattN,

It seems 360se switched to a profile directory structure much more similar to that of Chromium, some time after the de-emphasizing of startup migration wizard with the Fx 57 release.

My Windows desktop was recently corrupted and hopefully I'll have a working local m-c build and a patch ready some time next week. Keeping the ni? as a reminder.

Comment 2

[Matthew N. [:MattN]]

Thanks Hector! Perhaps we should change it to be a subclass of the Chrome/Chromium migrator depending on how much differs?

Comment 3

[Matthew N. [:MattN]]

Hector, can you assign a severity and priority please?

Comment 4

[Hector Zhao [:hectorz]]

(In reply to Matthew N. [:MattN] from comment #2)

Thanks Hector! Perhaps we should change it to be a subclass of the Chrome/Chromium migrator depending on how much differs?

Looks like this should work, at least for bookmarks, with one exception I have to make: 360se's files live in an user's AppData\Roaming directory, instead of AppData\Local like other browsers.

Our QA is testing my local build and confirming whether cookies/history/passwords also work as expected. We're also trying to find any data to support a decision regarding whether to keep the old 360se migrator or not.

Comment 5

[Hector Zhao [:hectorz]]

(In reply to Hector Zhao [:hectorz] from comment #4)

Looks like this should work, at least for bookmarks, with one exception I have to make: 360se's files live in an user's AppData\Roaming directory, instead of AppData\Local like other browsers.

Actually, although AppData\Roaming\360se6\User Data\Default\Bookmarks exists, its content is not really up to date. It looks like 360se switched to store the bookmarks in a somewhat encrypted format in more recent versions, which may prevent us from importing them at all. We're still looking for any available workarounds.

Comment 6

[Hector Zhao [:hectorz]]

(In reply to Hector Zhao [:hectorz] from comment #4)

... We're also trying to find any data to support a decision regarding whether to keep the old 360se migrator or not.

Data we're using: browser versions stats for https://www.firefox.com.cn/ from Google Analytics. 360se uses the exact same UA format as Chrome, but only update their Chromium version roughly once a year: SE8 => Chromium 45, SE9 => Chromium 55, SE10 => Chromium 63 & SE12 => Chromium 78.

SE8 is the last version that works with the existing implementation, and SE9 overtook it in popularity some time around Sept. 2017, shortly before the de-emphasizing of startup migration wizard with the Fx 57 release.

Last week, Chrome with version corresponding to SE8 accounts for less than 2% of the four versions mentioned above. We think it should be okay to replace the old 360se migrator implementation with a subclass of the Chrome/Chromium one.

Comment 7

[Hector Zhao [:hectorz]]

Attachment: [WIP] Bug 1659730 - Update 360se migrator to work with v9+. r?MattN

Comment 8

[Hector Zhao [:hectorz]]

Attachment: Bug 1659730 - Update 360se migrator to work with v9+. r=Gijs

Comment 9

[Hector Zhao [:hectorz]]

I've submitted my current WIP patch to phabricator.

Comment 10

[:Gijs (he/him)]

Hector, is this still broken? What needs to happen to drive this forward - it's a P1 but it's been sat for quite a while. :-)

Comment 11

[Hector Zhao [:hectorz]]

(In reply to :Gijs (he/him) from comment #10)

Hector, is this still broken? What needs to happen to drive this forward - it's a P1 but it's been sat for quite a while. :-)

Yes, it's still broken. I marked it as P1 and prepared a WIP patch, but never finished updating the unit test. I tried to restart working on it once around June, but was somehow distracted again.

I've rebased the patch on the latest central, and will try to get the test part ready for review early next week.

Keeping ni? as reminder.

Comment 12

[Hector Zhao [:hectorz]]

(In reply to Hector Zhao [:hectorz] from comment #11)

I've rebased the patch on the latest central, and will try to get the test part ready for review early next week.

Patch updated with tests, and marked as ready for review.

Latest stats from www.firefox.com.cn GAnalytics (30 days), and a table of what files exist for bookmarks in each version:

360 SE version	Chromium version	Traffic	|	Logged out	Logged in (legacy SQLite)	Backup (plaintext)	Backup (encrypted)
SE13	86.0.4240.198	72%	|	✗	✓	✓	✗
SE12	78.0.3904.108	12%	|	✗	✓	✓	✗
SE10	63.0.3239.132	8%	|	✗	✓	✓	✗
SE9	55.0.2883.87	5%	|	✓	✓	✓
SE8 or earlier	45.0.2454.101 etc.	3%	|	N/A	N/A	N/A	N/A

"✓" means plaintext file, "✗" means encrypted file.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dc43e9b0ba50
Update 360se migrator to work with v9+. r=Gijs

Comment 14

[Atila Butkovits]

Backed out for causing failures at test_360seMigrationUtils.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/cb52752027483e859d2400e9d2c6e347d5589b32

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=dc43e9b0ba50c764764e2e41bdbbca3817c7db32&selectedTaskRun=UE4aPGl1TB-12NzXCMNP-w.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=362015520&repo=autoland&lineNumber=2401

Comment 15

[Hector Zhao [:hectorz]]

(In reply to Atila Butkovits from comment #14)

Failure log: https://treeherder.mozilla.org/logviewer?job_id=362015520&repo=autoland&lineNumber=2401

It looks like the modification time of a test file will always be 2016-01-01, as set by bug 1288610.

Comment 16

[Hector Zhao [:hectorz]]

(In reply to Hector Zhao [:hectorz] from comment #15)

(In reply to Atila Butkovits from comment #14)

Failure log: https://treeherder.mozilla.org/logviewer?job_id=362015520&repo=autoland&lineNumber=2401

It looks like the modification time of a test file will always be 2016-01-01, as set by bug 1288610.

Patch updated with verified fixes: https://treeherder.mozilla.org/jobs?repo=try&revision=52c8a7ac096c6def2f841e4c7c46b869c8d1e1eb

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a3bd3bb0a2b2
Update 360se migrator to work with v9+. r=Gijs

Comment 18

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/a3bd3bb0a2b2

Comment 19

[Monica Chiorean]

I was able to reproduce the issue on Win10x64, using FF build 81.0a1(20200818214031).
Verified as fixed on Win10x64, using FF builds 97.0(20220202182137) and 98.0a1(20220206212741). I used 360browser version 13.1(86.0).