1659736 - FX_MIGRATION_BOOKMARKS_ROOTS telemetry shows wrong value when importing bookmarks from Internet Explorer

Status: VERIFIED FIXED

(Firefox :: Migration, defect, P1)

Description

[Peter Magyari (Desktop QA)]

Attachment: telemetry-issue-internet-explorer-import.JPG

Precondition
Make sure to only have Bookmarks/Favorites saved onto the Bookmarks/Favorites Toolbar in ie

Steps to reproduce

1. Open Firefox
2. Open the Bookmarks library by pressing "Ctrl+Shift+B" or from the Hamburger Menu
3. Press the Import/Export Arrows -> Import Data from another browsers... button
4. Select Internet Explorer
5. Press Continue and make sure the Favorites item is checked then press Continue again
6. Exit the Import Wizard by pressing Done
7. Navigate to about:telemetry and search for the FX_MIGRATION_BOOKMARKS_ROOTS under Keyed Histograms

Actual Results
The telemetry value shows "3"

Expected Results
Since we've only imported bookmarks from the Favorites toolbar the value should should show "1"

Note
Regardless of where the Bookmarks were stored in ie the value always shows "3"

Comment 1

[Sam Foster [:sfoster] (he/him)]

Can you take a look and triage this :jaws?

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1659736 - Move tracking of bookmark roots during IE migration later so the source is clearer.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/538c51598420
Move tracking of bookmark roots during IE migration later so the source is clearer. r=Gijs

Comment 4

[Razvan Maries]

Backed out for perma failures.

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedTaskRun=AIf3dk3ERai1HcHrDwjqgQ.0&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&searchStr=windows%2C10%2Cx64%2Copt%2Cxpcshell%2Ctests%2Ctest-windows10-64%2Fopt-xpcshell-e10s%2Cx1&revision=b55a70171699285b421188d84cbd19a880792da0&failure_classification_id=2

Log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=313977423&repo=autoland&lineNumber=6925

Backout: https://hg.mozilla.org/integration/autoland/rev/3afa7dd98397977db72ea93ba1253a327a1dcbaf

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f263318ebce4
Move tracking of bookmark roots during IE migration later so the source is clearer. r=Gijs

Comment 6

[Atila Butkovits]

Backed out for failure at test_Safari_bookmarks.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/ae59b435ba7e86aca38535e07e7b12609bb9a9b1

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedTaskRun=NlvKiQq2RtyCwCbZwXL0rQ.0&resultStatus=testfailed%2Cbusted%2Cexception&revision=f263318ebce4bef38b8a37d8eccf661e456fea0a&searchStr=xpc

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=314223775&repo=autoland&lineNumber=5363

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8a89b5580dd7
Move tracking of bookmark roots during IE migration later so the source is clearer. r=Gijs

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/8a89b5580dd7

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:jaws, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 10

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 9171769 [details]
Bug 1659736 - Move tracking of bookmark roots during IE migration later so the source is clearer.

Beta/Release Uplift Approval Request

• User impact if declined: telemetry reporting will be incorrect for IE migrations
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Follow QA test plan for IE migrator telemetry reporting
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Fix only affects telemetry reporting
• String changes made/needed: none

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9171769 [details]
Bug 1659736 - Move tracking of bookmark roots during IE migration later so the source is clearer.

Approved for 81.0b5.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/736cefecc0c7

Comment 13

[Raluca Popovici, Desktop QA]

Precondition:
Go to about:config and make sure "browser.migrate.showBookmarksToolbarAfterMigration" is set to true
Make sure to only have Bookmarks/Favorites saved onto the Bookmarks/Favorites Toolbar in ie

I followed the steps from the reported bug on Nightly 82.0a1 (2020-09-01)

1. Open Firefox
2. Open the Bookmarks library by pressing "Ctrl+Shift+B" or from the Hamburger Menu
3. Press the Import/Export Arrows -> Import Data from another browsers... button
4. Select Internet Explorer
5. Press Continue and make sure the Favorites item is checked then press Continue again
6. Exit the Import Wizard by pressing Done
7. Navigate to about:telemetry and search for the FX_MIGRATION_BOOKMARKS_ROOTS under Keyed Histograms

Actual Results:
The telemetry value still shows "3" instead of "1".

@[e-mail], am I missing something?

Comment 14

[Jared Wein [:jaws] (please needinfo? me)]

I can't reproduce that. I see 1 in my local testing. Are you sure you don't have a bookmark in your menu?

Comment 15

[Peter Magyari (Desktop QA)]

Verified fixed on Nightly 82.0a1 (20200903151816) and Beta 81.0b6 (20200903205131)