1659900 - [meta] Track SIMD instruction renamings and renumberings

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, task, P2)

Description

[Lars T Hansen [:lth]]

There are some fairly superficial SIMD instruction renamings probably on the way as the spec is being firmed up:

https://github.com/WebAssembly/simd/issues/297
https://github.com/WebAssembly/simd/issues/316

Mostly these change in wasmparser/wat, and here the changes are important so as to be interoperable.

But it would be good for us to rename also throughout the engine to stay more in sync with the source level names. (In fairness, we've diverged a bit on Wasm opcode names over time and could benefit from general cleanup.)

Comment 1

[Lars T Hansen [:lth]]

The naming changes have landed in the spec interpreter, so I guess we're not compliant now.

Comment 2

[Lars T Hansen [:lth]]

Also https://github.com/WebAssembly/simd/issues/332.

Comment 3

[Lars T Hansen [:lth]]

SIMD renaming is landing in wasm-tools: https://github.com/bytecodealliance/wasm-tools/pull/105. It'll likely be hellish to merge this as we'll have to update instruction names in many of our (currently private) simd tests. Let's hope we don't need an emergency fix for wasm-tools...

Comment 4

[Lars T Hansen [:lth]]

Renamings for the three tickets mentioned in comment 0, comment 2 will be landed as part of bug 1669668. The present bug will remain open to track further renamings.

Comment 5

[Lars T Hansen [:lth]]

There's a Final Renumbering coming once the instruction set is frozen, any day now.

Comment 6

[Lars T Hansen [:lth]]

I think this is done?