Closed
Bug 1659970
Opened 4 years ago
Closed 4 years ago
JS error on startup on a clean profile: PlacesUtils.getToolbarFolderCount is not a function
Categories
(Firefox :: Migration, defect)
Firefox
Migration
Tracking
()
RESOLVED
FIXED
81 Branch
Tracking | Status | |
---|---|---|
firefox-esr78 | --- | unaffected |
firefox79 | --- | unaffected |
firefox80 | --- | unaffected |
firefox81 | + | fixed |
People
(Reporter: Gijs, Assigned: jaws)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
[Tracking Requested - why for this release]:
Broken bookmarks toolbar detection code
STR:
- open nightly profile manager
- create new profile
- start
- open browser console
ER:
no errors
AR:
new error pointing to https://searchfox.org/mozilla-central/rev/23dd7c485a6525bb3a974abeaafaf34bfb43d76b/browser/components/places/PlacesUIUtils.jsm#1195
I'm guessing
let getToolbarFolderCount = () => {
let toolbarFolder = PlacesUtils.getFolderContents(
PlacesUtils.bookmarks.toolbarGuid
).root;
let toolbarChildCount = toolbarFolder.childCount;
toolbarFolder.containerOpen = false;
return toolbarChildCount;
};
which was removed from BrowserGlue.jsm was supposed to make it into PlacesUtils
to be a method there?
Flags: needinfo?(jaws)
Assignee | ||
Comment 1•4 years ago
|
||
It was renamed but this callsite wasn't updated.
Flags: needinfo?(jaws)
Assignee | ||
Comment 2•4 years ago
|
||
Updated•4 years ago
|
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/cf609f76de9f
Fix call to renamed getChildCountForFolder method. r=Gijs
Comment 4•4 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch
Updated•4 years ago
|
Updated•3 years ago
|
Keywords: regression
Updated•3 years ago
|
Has Regression Range: --- → yes
You need to log in
before you can comment on or make changes to this bug.
Description
•