1659997 - Perma arm64cl js/src/jit-test/tests/wasm/ref-types/externref.js | Hit MOZ_CRASH(Bad type) at /builds/worker/checkouts/gecko/js/src/wasm/WasmCraneliftCompile.cpp:615 (code -11, args "") [0.3 s]

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, defect, P1)

Description

[Treeherder Bug Filer]

Filed by: nbeleuzu [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=313424214&repo=mozilla-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/WM3p4q3nTVWhZEuCruDJ-w/runs/0/artifacts/public/logs/live_backing.log

---

[task 2020-08-19T10:57:44.649Z] TEST-PASS | js/src/jit-test/tests/wasm/ref-types/externref-val-tracing.js | Success (code 0, args "--baseline-eager") [3.8 s]
[task 2020-08-19T10:57:44.653Z] Hit MOZ_CRASH(Bad type) at /builds/worker/checkouts/gecko/js/src/wasm/WasmCraneliftCompile.cpp:615
[task 2020-08-19T10:57:44.653Z] Exit code: -11
[task 2020-08-19T10:57:44.653Z] FAIL - wasm/ref-types/externref.js
[task 2020-08-19T10:57:44.653Z] TEST-UNEXPECTED-FAIL | js/src/jit-test/tests/wasm/ref-types/externref.js | Hit MOZ_CRASH(Bad type) at /builds/worker/checkouts/gecko/js/src/wasm/WasmCraneliftCompile.cpp:615 (code -11, args "") [0.3 s]
[task 2020-08-19T10:57:44.654Z] INFO exit-status : -11
[task 2020-08-19T10:57:44.654Z] INFO timed-out : False
[task 2020-08-19T10:57:44.654Z] INFO stderr 2> Hit MOZ_CRASH(Bad type) at /builds/worker/checkouts/gecko/js/src/wasm/WasmCraneliftCompile.cpp:615
[task 2020-08-19T10:57:44.896Z] Hit MOZ_CRASH(Bad type) at /builds/worker/checkouts/gecko/js/src/wasm/WasmCraneliftCompile.cpp:615
[task 2020-08-19T10:57:44.897Z] Exit code: -11
[task 2020-08-19T10:57:44.897Z] FAIL - wasm/ref-types/externref.js
[task 2020-08-19T10:57:44.897Z] TEST-UNEXPECTED-FAIL | js/src/jit-test/tests/wasm/ref-types/externref.js | Hit MOZ_CRASH(Bad type) at /builds/worker/checkouts/gecko/js/src/wasm/WasmCraneliftCompile.cpp:615 (code -11, args "--no-blinterp --no-baseline --no-ion --more-compartments") [0.2 s]
[task 2020-08-19T10:57:44.897Z] INFO exit-status : -11
[task 2020-08-19T10:57:44.897Z] INFO timed-out : False
[task 2020-08-19T10:57:44.897Z] INFO stderr 2> Hit MOZ_CRASH(Bad type) at /builds/worker/checkouts/gecko/js/src/wasm/WasmCraneliftCompile.cpp:615
[task 2020-08-19T10:57:44.932Z] Hit MOZ_CRASH(Bad type) at /builds/worker/checkouts/gecko/js/src/wasm/WasmCraneliftCompile.cpp:615
[task 2020-08-19T10:57:44.932Z] Exit code: -11
[task 2020-08-19T10:57:44.932Z] FAIL - wasm/ref-types/externref.js

Comment 1

[Chris Fallin [:cfallin]]

Interesting -- failure is on x64, I think. I'll take a look.

Comment 2

[Lars T Hansen [:lth]]

My bad. If it's x64 it's not P1, feel free to demote as appropriate.

Comment 3

[Chris Fallin [:cfallin]]

Oh, nope, I missed this in the logs: --enable-simulator=arm64. Definitely P1. Investigating!

Comment 4

[Chris Fallin [:cfallin]]

So I've bisected this (on native aarch64 hardware with --wasm-compiler=cranelift) down to hg commit ea8dd38c1de078b51916164ea786903365860117, which is:

Author: Ryan Hunt <[e-mail]>
Date:   Tue Aug 18 16:50:27 2020 +0000

    Bug 1561521 - Vendor the latest wat. r=lth

    Differential Revision: https://phabricator.services.mozilla.com/D85052

Ryan, could you investigate? The errors look like:

/home/cfallin/moz/mozilla-unified/js/src/jit-test/lib/wasm.js:12:13 CompileError: at offset 15: (optref T) types not enabled  

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1561521

Comment 6

[Intermittent Failures Robot]

11 failures in 4100 pushes (0.003 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 11

Platform breakdown:

• linux64: 11

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1659997&startday=2020-08-17&endday=2020-08-23&tree=all

Comment 7

[Ryan Hunt [:rhunt] (on leave until early May)]

Attachment: Bug 1659997 - wasm: Use abstract reference type in switch in cranelift compile. r?lth

Fixes a regression from the refactoring in bug 1561521, where TC::Ref was previously
used as the value to represent any reference value in ValType.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/48d4a2a7a4e2
wasm: Use abstract reference type in switch in cranelift compile. r=lth

Comment 9

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/48d4a2a7a4e2

Comment 10

[Intermittent Failures Robot]

6 failures in 4046 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 6

Platform breakdown:

• linux64: 6

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1659997&startday=2020-08-24&endday=2020-08-30&tree=all