16601 - [New Skin] Need disabled image for submenu arrow

Status: VERIFIED FIXED

(SeaMonkey :: General, defect, P3)

Description

[Crysgem]

Mozilla Build ID: 1999101511

Under the File menu is codified the option "Offline >". The option is disabled
(perpetually, to my experience), but the arrow pointer would indicate else - it
is black, like to the color of an enabled option, whereas a commoner's UI
notions expect the arrow to be dimmed.

Comment 1

[Peter Trudelle]

reassigning to shaver per hyatt

Comment 2

[Michael Lowe]

Here is the rule needed in skin.css.   As well, I'm attaching a new
menu-arrow-disabled.gif file which looks better than the current one.

menu[disabled="true"] > .menu-right {
  list-style-image: url("chrome://global/skin/menu-arrow-disabled.gif");
}

Comment 3

[Michael Lowe]

Attachment: new image

Comment 4

[Michael Lowe]

Still relevant in new skin.

Comment 5

[hangas]

German: please approve this change, and I will check it in.

Comment 6

[german]

approved. the only that worries me is that the color of the traingle is hardcoded
and therefore not easily skinnable. Too bad we cannot draw that triangle with the
css font color. Oh well is grey is probably good enough for the 90% case,
certainly much better than black! Thanks.

Comment 7

[german]

approved. the only that worries me is that the color of the traingle is hardcoded

and therefore not easily skinnable. Too bad we cannot draw that triangle with the

css font color. Oh well is grey is probably good enough for the 90% case,

certainly much better than black! Thanks.

Comment 8

[hangas]

Have image in my local tree.  Waiting for tree to open for M12 checkins.

Comment 9

[hangas]

New icon checked in.

Comment 10

[Claudius Gayle]

I'm looking at the 1999111108 comm opt linux build
and the black triangle next to File-->Offline looks just
like the rest of them - black.
Reopening until I can see this.

Comment 11

[leger]

Clearing FIXED resolution due to reopen.

Comment 12

[Michael Lowe]

The CSS style rule needs to be checked in.  See comments from 10/21/99 23:06 for
example (may be out of date by now).

Comment 13

[hangas]

Thanks Michael.  This is now checked in.

Comment 14

[Claudius Gayle]

VERIFIED fixed in the 199911109 builds

Comment 15

[leger]

Moving all UE/UI bugs to new component: User Interface: Design Feedback
UE/UI component will be deleted.

Comment 16

[Pulsebot]

Pushed by ffxbld-merge:
https://hg.mozilla.org/releases/mozilla-beta/rev/4eb5a8e4b960
[fenix] Update Android Components version to 67.0.20201116143052. (https://github.com/mozilla-mobile/fenix/pull/16601)