Closed Bug 1660218 Opened 9 months ago Closed 9 months ago

Printed output is not properly adjusted in Landscape mode

Categories

(Core :: Printing: Output, defect, P1)

Product:
Core
Component:
Printing: Output
Version:
Firefox 81
Platform:
All
macOS
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
81 Branch
Tracking Flags:
Tracking Status
firefox-esr68 --- unaffected
firefox-esr78 --- unaffected
firefox79 --- unaffected
firefox80 --- unaffected
firefox81 --- verified

People

(Reporter: Anca, Assigned: jfkthame)

References

(Blocks 2 open bugs, Regression)

Details

(Keywords: regression, Whiteboard: [print2020_v81][old-ui+])

Attachments

(2 files)

screenshot issue.jpg
356.34 KB, image/jpeg
Details
Bug 1660218 - Ensure consistent handling of portrait/landscape dimension swapping in nsPrintSettingsX. r=jwatt
47 bytes, text/x-phabricator-request
Details | Review
Attached image screenshot issue.jpg —

Affected versions

  • 81.0a1

Affected platforms

  • macOS 10.15
  • macOS 10.14

Unaffected platforms

  • Windows 10
  • Ubuntu 20.04

Prerequisites

  • print.tab_modal.enabled is set on false

Steps to reproduce

  1. Launch Firefox
  2. Open any page and hit CTRL + P
  3. Change orientation to Landscape
  4. Print to paper

Expected result

  • The content is properly adjusted to the Landscape mode

Actual result

  • The content is not properly adjusted to the Landscape mode

Regression range

Additional notes

  • With print.tab_modal.enabled set on true, the issue is not reproducible

Suggested severity

  • I think this is a S2

This feels like a Core::Printing:Output bug to me…

Component: Printing → Printing: Output
Product: Toolkit → Core

Set relevant fields based on comment 0.

Severity: -- → S2
Flags: needinfo?(jfkthame)
Regressions: 1653354

This must be caused by the change to nsPrintSettingsX::GetEffectivePageSize; I'll look into what that was about.

Assignee: nobody → jfkthame
Flags: needinfo?(jfkthame)
Priority: -- → P1
Pushed by jkew@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/439c806d4898
Ensure consistent handling of portrait/landscape dimension swapping in nsPrintSettingsX. r=jwatt

https://hg.mozilla.org/mozilla-central/rev/439c806d4898

Status: NEW → RESOLVED
Closed: 9 months ago
status-firefox81: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch

Verified fixed with the latest Nightly 81.0a1 (2020-08-24) on macOS 10.15.

Status: RESOLVED → VERIFIED
status-firefox81: fixed → verified

This should have been marked regressed by bug 1653354.

Regressed by: 1653354
No longer regressions: 1653354
You need to log in before you can comment on or make changes to this bug.