Closed Bug 1660294 Opened 4 years ago Closed 4 years ago

Two small non-functional print tweaks

Categories

(Core :: Printing: Output, task)

task

Tracking

()

RESOLVED FIXED
81 Branch
Tracking Status
firefox81 --- fixed

People

(Reporter: dholbert, Assigned: dholbert)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

I'm moving Part 0 and Part 1 from bug 1631452 over to this bug, to land those trivial patches (to get them out of my local queue & to get the documentation-tweak in part 1 to be published, for clarity). They're not really integrally tied to bug 1631452 so there's no need to gate them on that whole bug being ready.

Blocks: 1631452
Severity: -- → S3

phab pages for patches here, in case phabricator doesn't port them over:
https://phabricator.services.mozilla.com/D86797
https://phabricator.services.mozilla.com/D86798

I'm not actually renaming these APIs yet, to avoid bitrotting folks & shaking
things up too much, but we should consider renaming them soon. This patch just
makes the subtlety and pages-vs-sheets distinction a bit clearer in the
documentation.

Pushed by dholbert@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c338efe4ffd0
part 0: Directly initialize nsSharedPageData member-var, and adjust its documentation. r=TYLin
https://hg.mozilla.org/integration/autoland/rev/b13b671dfec9
part 1: Tag the page-number-related attributes in nsIWebBrowserPrint as potentially needing a rename (since they're actually about *sheet* numbers). r=TYLin

(In reply to Daniel Holbert [:dholbert] from comment #1)

phab pages for patches here, in case phabricator doesn't port them over:
https://phabricator.services.mozilla.com/D86797
https://phabricator.services.mozilla.com/D86798

It seems phabricator / bugzilla /moz-phab integration is good enough that it can detect patches moved to another bug :)

Yup! It just took longer than I expected, and I started to get suspicious. :)

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch
Blocks: 1669762
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: