Closed Bug 1660425 Opened 4 years ago Closed 4 years ago

Hitting space key when typing a token alias no longer deletes the autocomplete result

Categories

(Firefox :: Address Bar, defect, P2)

Product:
Firefox
Component:
Address Bar
Platform:
Desktop
All
Type:
defect
Points:
1

Tracking

()

Status:
VERIFIED FIXED
Milestone:
81 Branch
Iteration:
81.2 - Aug 10 - Aug 23
Tracking Flags:
Tracking Status
firefox-esr68 --- unaffected
firefox-esr78 --- unaffected
firefox79 --- unaffected
firefox80 --- wontfix
firefox81 --- verified

People

(Reporter: atrif, Assigned: bugzilla)

References

Details

(Keywords: regression)

Attachments

(2 files)

search_suggestion
115.40 KB, video/x-matroska
Details
Bug 1660425 - Use the entire search string when autofilling in UrlbarProviderTokenAliasEngines. r?adw!
47 bytes, text/x-phabricator-request
Details | Review

Affected versions

  • 81.0a1 (20200820212107)
  • 80.0RC2 (20200818235255)

Affected platforms

  • Windows 10x64
  • macOS 11
  • Ubuntu 18.04

Steps to reproduce

  1. Open Firefox and focus the address bar.
  2. Type @am for example for a search suggestion autocomplete.
  3. Hit Space key.

Expected result

  • Autocomplete search suggestion is deleted leaving only the typed letters.

Actual result

  • The selection is moved one letter.

Regression range

Notes

  • Attached a screen recording.
  • After hitting Space and unfocusing the address bar shows only the typed word and after refocusing shows the autocomplete result.

Suggested Severity: S3

Attached video search_suggestion —

Firefox 79.0 (20200720193547) is unaffected. Sorry, I miss clicked the flags.

Has Regression Range: --- → yes
Has STR: --- → yes
status-firefox79: affected → unaffected
Assignee: nobody → htwyford
Severity: -- → S3
Status: NEW → ASSIGNED
Iteration: --- → 81.2 - Aug 10 - Aug 23
Flags: needinfo?(htwyford)
Priority: -- → P2
Summary: Hitting space key on a provider search suggestion no longer deletes the autocomplete result → Hitting space key when typing a token alias no longer deletes the autocomplete result
Points: --- → 1
Attachment #9171483 - Attachment description: Bug 1660425 - Stop autofilling token aliases when the search string contains a space. r?adw → Bug 1660425 - Use the entire search string when autofilling in UrlbarProviderTokenAliasEngines. r?adw!
Pushed by htwyford@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c089d805db48
Use the entire search string when autofilling in UrlbarProviderTokenAliasEngines. r=adw

https://hg.mozilla.org/mozilla-central/rev/c089d805db48

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox81: fix-optional → fixed
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch
Regressions: 1660681

Verified fixed with Firefox 81.0 (20200914232702) on Windows 10x64, macOS 11 beta (20A5364e) and Ubuntu 18.04.

Status: RESOLVED → VERIFIED
status-firefox81: fixed → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: