1660463 - Print selection is available and doesn’t work properly for a pdf document

Status: VERIFIED FIXED

(Core :: Printing: Output, defect, P1)

Description

[Emil Ghitta, QA [:emilghitta]]

Attachment: pdfSelection.gif

Affected versions

• 81.0a1 (BuildId:20200821033746)

Affected platforms

• Windows 10 64bit
• macOS 10.14
• Ubuntu 18.04 64bit

Steps to reproduce

1. Launch Firefox.
2. Open a pdf file.
3. Select a portion of text.
4. Open the system modal.
5. Click the “Selection” option from the page range.
6. Print the file as pdf or to paper.

Expected result

• The selection is printed or the print “selection” option is not available for a pdf file.

Actual result

• If printing to paper no actual print job is started. If the selection is printed to pdf it will output a blank pdf document.

Regression Window

• This seems to be a regression:
• Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=09921685a632ade2b9da3e027f433c12902bccd3&tochange=ad5909461c4af7de17369693d7c75922dccb4d96
• Potential regressor: Bug 1653334

Additional Information

• For further information regarding this issue please observe the attached screencast.
• This seems to affect both the new and old ui
• [Suggested Severity] S3

Comment 1

[Emil Ghitta, QA [:emilghitta]]

Hi Bob!

It seems that mozregression pointed out Bug 1653334 part 2: Cache the selection ranges on subdocuments as we build the nsPrintObject tree. r=jwatt for causing this regression.

Can you please take a look?

Thank you!

Comment 2

[Bob Owen (:bobowen)]

I'll take a look at this.

Comment 3

[Bob Owen (:bobowen)]

The problem is that I didn't allow for mDisallowSelectionPrint in my change, patch on the way.

Comment 4

[Bob Owen (:bobowen)]

Attachment: Bug 1660463: Only allow printing of a selection when mDisallowSelectionPrint is false. r=jwatt!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/291ac0594994
Only allow printing of a selection when mDisallowSelectionPrint is false. r=jwatt

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/291ac0594994

Comment 7

[Jonathan Watt [:jwatt]]

Comment on attachment 9171694 [details]
Bug 1660463: Only allow printing of a selection when mDisallowSelectionPrint is false. r=jwatt!

Beta/Release Uplift Approval Request

• User impact if declined: Printing PDFs makes "print selection" an available option, but we don't support that for PDFs. This is a regression for the old UI as well as a bug with the new print UI.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Simple flag check to trigger existing codepath to hide option in UI.
• String changes made/needed:

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9171694 [details]
Bug 1660463: Only allow printing of a selection when mDisallowSelectionPrint is false. r=jwatt!

Approved for 81.0b2.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/d32cb1a88e06

Comment 10

[Emil Ghitta, QA [:emilghitta]]

This is verified fixed using Firefox 82.0a1 (BuildId:20200827212940) and Firefox 81.0b3 (BuildId:20200827203325) on Windows 10 64bit, macOS 10.14 & Ubuntu 18.04 64bit.

Comment 11

[Maria Berlinger [:mberlinger], Services QA]

https://testrail.stage.mozaws.net/index.php?/cases/view/1082828