1660517 - Megabar ignoring reduced motion settings

Status: RESOLVED INVALID

(Firefox :: Address Bar, defect)

Description

[MarjaE]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:79.0) Gecko/20100101 Firefox/79.0

Steps to reproduce:

According to bug 1629303, the megabar no longer expands when users select prefers reduced motion via either the system settings or ui.prefersReducedMotion 1.

Actual results:

The Megabar expands with either or both settings.

Expected results:

The Megabar should not expand with these settings.

This may point to other issues where settings which use prefers-reduced-motion are not detecting it.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[Drew Willcoxon :adw]

As far as I can tell, ui.prefersReducedMotion doesn't do anything on Windows and macOS. Bug 1629303 comment 59 says it works on KDE. So I don't think there's any expectation that it should work broadly, and if there is, that's a different bug.

On both Windows and macOS, when I enable the system reduce-motion preference, the address bar does not expand while it remains closed. Once the address bar's view opens and results are shown, it does expand, and that's the expected behavior. In other words, when reduce motion is enabled, the address bar is expected to stop expanding only when it's closed. See bug 1629303 comment 61 and 62.

Are you seeing something different from what I just described? If not, then that's the expected behavior.

Comment 3

[MarjaE]

Yes. If I click on the Megabar, it expands.

Comment 4

[MarjaE]

I don't know what "open" or "closed" would mean here.

Comment 5

[Marco Bonardo [:mak]]

There are 2 kind of "expansions" and it's unclear which of them you are referring to:

1. the urlbar input field border expands by a few pixels when it is focused. This happens for example if you click on the Open New Tab + button. ui.prefersReducedMotion disables that, but you must be sure you are creating a NUMERIC preference and set it to 1, do not create a boolean preference, it won't work.
2. when you click on the input field, it opens the results panel showing Top Sites from your New Tab Page. This list can be completely customized to your likes from about:home. If you don't want to see Top Sites, disable the Top Sites checkbox under Address Bar in about:preferences#privacy.

Comment 6

[MarjaE]

I'm referring to the 1st. I get both.

And neither system settings, nor ui.prefersReducedMotion 1 as a numerical value, stop this expansion in Firefox 79.

Comment 7

[MarjaE]

Attachment: Partial Screen Recording

Note that I am using some of my own css for fonts and font sizes.

Comment 8

[Marco Bonardo [:mak]]

Actually from the video it looks like you are referring to the second one... Did you try unchecking the Top Sites option on the page and see how it behaves?

Comment 9

[MarjaE]

When I watch the video, it shows the 1st and 2nd types. And for whatever reason, it looks like the 2nd Top Sites preferences controls both the 1st and 2nd.

With my font and font size settings, a search for "bar" in about:preferences does not show the "top sites" preference. I don't know if using the default settings and being able to see them would help. Since scrolling is still broken in about:preferences, the "top sites" setting is not very discoverable.

Comment 10

[MarjaE]

Attachment: Search for "Bar"

Comment 11

[Drew Willcoxon :adw]

The video shows case 2. That's the expected behavior. With reduced motion enabled, the input will expand when the view opens and shows results.

Are you saying that you have an accessibility need for this not to happen, or just that you don't like it?

Comment 12

[MarjaE]

Another user reported an accessibility need in an earlier bug, which was reoprted fixed and closed. And the video shows the megabar expanding and the top sites.

Comment 13

[Drew Willcoxon :adw]

It's expected that the megabar expands and shows top sites when when reduced motion is enabled. That's what Marco and I have been explaining in this bug and the other one linked here. It sounds like there's no accessibility need in this bug, so I'll close it.

Comment 14

[MarjaE]

The user making the original complaint was quite specific that the expanding megabar was the seizure trigger. And if you click on it, it still expands, unless you switch unrelated and undiscoverable settings. That another problem has been fixed doesn't change this.

See bug 1629303.

Comment 15

[Marco Bonardo [:mak]]

(In reply to MarjaE from comment #14)

The user making the original complaint was quite specific that the expanding megabar was the seizure trigger.

Yes, that was about the expansion of the input field border on focus. Opening the results pane causes movemeent regardless of any extension of the border.

Comment 17

[Andy Bajka]

I hope that enough people will complain about the expanding megabar and it will be removed.

For now one way to disable the expanding megabar is to create a userChrome.css and add the following code:

@-moz-document url(chrome://browser/content/browser.xhtml) {
    #urlbar[breakout][breakout-extend] {
        top: calc((var(--urlbar-toolbar-height) - var(--urlbar-height)) / 2) !important;
        left: 0 !important;
        width: 100% !important;
    }

    #urlbar[breakout][breakout-extend] > #urlbar-input-container {
        height: var(--urlbar-height) !important;
        padding-block: 0 !important;
        padding-inline: 0 !important;
    }

    #urlbar[breakout][breakout-extend] > #urlbar-background {
        animation-name: none !important;
        box-shadow: 0 1px 4px rgba(0, 0, 0, .05) !important;
    }
}