Closed Bug 1660526 Opened 5 months ago Closed 5 months ago

Tweak AddToRootSessionHistory and AddChildSHEntryHelper to make them easier to follow

Categories

(Core :: DOM: Navigation, defect)

defect

Tracking

()

RESOLVED FIXED
81 Branch
Tracking Status
firefox81 --- fixed

People

(Reporter: smaug, Assigned: smaug)

Details

Attachments

(1 file)

Looks like they get always root browsing context as param, so better to hint that in the argument name.
And there are two AddChildSHEntryHelper methods, where the only caller for the other one is the another one. So those could be merged.

Pushed by opettay@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b8753e7cb414
Tweak AddToRootSessionHistory and AddChildSHEntryHelper to make them easier to follow, r=annyG
Backout by btara@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1b4621f57338
Backed out changeset b8753e7cb414 for session related asan failures CLOSED TREE
Pushed by btara@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cde067f600fe
Tweak AddToRootSessionHistory and AddChildSHEntryHelper to make them easier to follow, r=annyG

Sorry for the backout. Relanded.

Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch
You need to log in before you can comment on or make changes to this bug.