Closed
Bug 1660526
Opened 4 years ago
Closed 4 years ago
Tweak AddToRootSessionHistory and AddChildSHEntryHelper to make them easier to follow
Categories
(Core :: DOM: Navigation, defect)
Core
DOM: Navigation
Tracking
()
RESOLVED
FIXED
81 Branch
| Tracking | Status | |
|---|---|---|
| firefox81 | --- | fixed |
People
(Reporter: smaug, Assigned: smaug)
Details
Attachments
(1 file)
Looks like they get always root browsing context as param, so better to hint that in the argument name.
And there are two AddChildSHEntryHelper methods, where the only caller for the other one is the another one. So those could be merged.
|
Assignee | |
Comment 1•4 years ago
|
||
|
|
Assignee | |
Comment 2•4 years ago
|
||
Pushed by opettay@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b8753e7cb414 Tweak AddToRootSessionHistory and AddChildSHEntryHelper to make them easier to follow, r=annyG
Backout by btara@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1b4621f57338 Backed out changeset b8753e7cb414 for session related asan failures CLOSED TREE
Pushed by btara@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/cde067f600fe Tweak AddToRootSessionHistory and AddChildSHEntryHelper to make them easier to follow, r=annyG
|
||
Comment 6•4 years ago
|
||
Sorry for the backout. Relanded.
|
|
||
Comment 7•4 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox81:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•