Closed Bug 1660570 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 25195 - [css-flex] Use definite cross size and aspect ratio for flex base size

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox82 fixed)

Status:
RESOLVED FIXED
Milestone:
82 Branch
Tracking Flags:
Tracking Status
firefox82 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 25195 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/25195
Details from upstream follow.

David Grogan <dgrogan@chromium.org> wrote:

[css-flex] Use definite cross size and aspect ratio for flex base size

When an aspect-ratio item has a definite cross size, we are supposed to
compute the flex base size by multiplying those two. Blink did this when
the item had a computed definite cross size, but not when the item had a
definite cross size due to stretching.

Firefox has the same bug.

The modified canvas test relied on the buggy behavior. The tests we now
fail also assert the buggy behavior, but are only one-way synced from
mozilla's repository, so we can't change them.

This fix is behind a flag.

Bug: 704294
Change-Id: Ie17c451c7ec81ccb36fb96ff1543885bd7352bcc
Reviewed-on: https://chromium-review.googlesource.com/2368321
WPT-Export-Revision: 46e627863505685ac66bb1d4764d6d9035ac1e9a

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests

Status Summary

Firefox

OK : 1
FAIL: 2

Chrome

OK : 1
FAIL: 2

Safari

OK : 1
FAIL: 2

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-flexbox/canvas-dynamic-change-001.html
.flexbox 1: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-flexbox/flex-aspect-ratio-img-row-006.html: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/54cc4ecca32b
[wpt PR 25195] - [css-flex] Use definite cross size and aspect ratio for flex base size, a=testonly
https://hg.mozilla.org/integration/autoland/rev/35b297a33602
[wpt PR 25195] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/54cc4ecca32b
https://hg.mozilla.org/mozilla-central/rev/35b297a33602

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox82: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch
You need to log in before you can comment on or make changes to this bug.