Platform information for Thunderbird 78.1.1 shows 78.1.0
Categories
(Thunderbird :: Build Config, defect)
Tracking
(Not tracked)
People
(Reporter: Fallen, Unassigned)
Details
Looking at platform.ini from Thunderbird 78.1.1, it shows Milestone=78.1.0. As a result, Services.appinfo.platformVersion returns 78.1.0, which means among other things that add-ons with strict_min_version set won't work correctly.
Too late for that release, but if there is some sort of build config thing we need to fix going forward we probably should.
|
||
Comment 1•5 years ago
|
||
It is correct.
For Firefox platform and application versions line up. The line is rather blurred between platform and application.
Thunderbird versions can be slightly different depending on what versions of Firefox are available. In this case, there was no Firefox 78.1.1 so Thunderbird 78.1.1 is built on Firefox 78.1.0.
To get that in an externsion you should be able to use Services.appinfo.version. I just checked Thunderbird 78.1.1 in devtools:
Services.appinfo.platformVersion
"78.1.0"
Services.appinfo.version
"78.1.1"
|
|
||
Updated•5 years ago
|
|
Reporter | |
Comment 2•5 years ago
|
||
How often do we run into cases where there is no platform version for the application version? I'm ok using a different variable if I am accessing this in code, but why I came across it:
An add-on setting "strict_min_version": "78.1.1" in the manifest will not actually be able to install into Thunderbird 78.1.1, because the add-on manager code compares to the toolkit version. Therefore, for purposes of the add-on it thinks its version is 78.1.0, and the install fails.
To fix this we'd either have to convince the extensions team to have that check be against the application version instead of the toolkit version, or fake the platform version so that it always matches the application version for Thunderbird.
|
|
||
Comment 3•5 years ago
|
||
Looking at the history for Thunderbird 68, we had 68.1.1, 68.1.2, 68.2.1, 68.2.2, 68.3.1, and 68.8.1 where application and platform versions would have diverged.
For Thunderbird 78, it has differed on 78.0.1 (platform was 78.0.2) and 78.1.1 where platform was 78.1.1.
Whether or not there were MailExtension changes where this sort of thing made a difference I don't know.
Perhaps short term we don't introduce changes like this in a patch release (eg held this until 78.2).
Given that MailExtensions by definition are a Thunderbird thing I think it does make sense to check compatibility with the application version.
Description
•