1660651 - Image disappears in the result page of firefox screenshot

Status: VERIFIED FIXED

(Firefox :: Screenshots, defect, P2)

Description

[slanterns.w]

Attachment: Snipaste_2020-08-23_07-30-01.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:81.0) Gecko/20100101 Firefox/81.0

Steps to reproduce:

Take screenshot with firefox screenshot

Actual results:

Image disappears in the result page of firefox screenshot

Expected results:

Image shows in the result page of firefox screenshot

Comment 1

[BugBot [:suhaib / :marco]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[Cosmin Muntean [:cmuntean], Ecosystem QA]

I have managed to reproduce the issue when using the "Save visible" and "Save full page" options of Screenshots on the latest Nightly 81.0a1 build (Build ID: 20200824094458) on Windows 10 x64 and macOS 10.15.6.

[Steps to reproduce]:

1. Navigate to any website.
2. Click the "Page Actions" button from the awesome bar.
3. Click the "Take a Screenshot" button.
4. Click the "Save visible" or "Save ful page" button.
5. Observe the screenshot preview.

[Actual results}:

• The screenshot preview looks broken.

The issue is not reproducible with older Nightly 81.0a1 versions. Considering this using mozregression tools I have found the bug wich introduced this issue:

• Last good revision: e140c6cd2eb944579ec99458638879c9b8501920
• First bad revision: 0288ef9ab65b6211fd2e96ae6ead9284c41f02fd
• Pushlog: Link

From this pushlog it seems that Bug 1658878 introduced this issue. Andrea can you please take a look over this issue?

Comment 3

[Jens Stutte [:jstutte]]

Hi Shane, can you help us to get a Severity set here? Thank you!

Comment 5

[Shane Caraveo (:mixedpuppy)]

Tom is doing some stuff for screenshot, and I think maybe bwinton might end up owning this somehow.

Comment 6

[Blake Winton (:bwinton) (:☕️)]

(I think Emma and Sam are the new triage owners, so redirecting to one of them.)

Comment 7

[Shane Caraveo (:mixedpuppy)]

Thanks Blake.

Comment 9

[Emma Malysz]

Since it's a privacy experiment, it's going to be disabled for 81, but we should figure out why this is happening.

Ultimately, the assumption that blobURLs are openable on the same agent-cluster-id only (https://searchfox.org/mozilla-central/rev/5d45da52f2fa423c9f4505ede5d1a5c7d48163fc/dom/file/uri/BlobURLProtocolHandler.cpp#770-775) is causing us to consider this as a bad URL (https://searchfox.org/mozilla-central/rev/5d45da52f2fa423c9f4505ede5d1a5c7d48163fc/dom/ipc/ContentParent.cpp#6939-6940) and break the screenshots.

:smaug, do you have any advice on how we could fix this?

Comment 10

[Olli Pettay [:smaug][[e-mail]]]

Show image in an iframe which is in the same agent-cluster?

Comment 11

[Emma Malysz]

Attachment: Bug 1660651, create URL for screenshots image using the iframe's contentWindow

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/22c4011d38b6
create URL for screenshots image using the iframe's contentWindow r=sfoster

Comment 13

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/22c4011d38b6

Comment 14

[Cosmin Muntean [:cmuntean], Ecosystem QA]

I have verified this issue and is no longer reproducible on the latest Nightly 83.0a1 build (Build ID: 20201001094020). I have tested this on Windows 10 x64, macOS 10.15.6 and Ubuntu 20.04 x64.

• The image is correctly displayed in the screenshot preview window.