1660745 - Update encoding_rs to 0.8.31

Status: RESOLVED FIXED

(Core :: Internationalization, defect, P3)

Description

[Henri Sivonen (:hsivonen)]

Take the change from https://github.com/hsivonen/encoding_rs/pull/53 .

Most likely this doesn't change anything in practice, but in principle, without this change LLVM had the permission to perform potentially breaking optimizations on this code. However, unless this function ever got inlined by LTO so far that LLVM had the slice bounds available at optimization time, I don't see how a breaking optimization could have been triggered. Furthermore, for tier-1 platforms, Firefox doesn't enable this bit of code. (Investigating whether the same bug exists in code that Firefox does enable for tier-1 is still to be done.)

Still, it's best to fix this.

Comment 1

[Henri Sivonen (:hsivonen)]

Attachment: Bug 1660745 - Update encoding_rs to 0.8.31 and packed_simd to 0.3.7.

Comment 2

[Henri Sivonen (:hsivonen)]

The pattern occurs more. Let's fix them all.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:m_kato, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/812d9dbedc75
Update encoding_rs to 0.8.31 and packed_simd to 0.3.7. r=hsivonen

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/812d9dbedc75