1660792 - Button value not submitted when posting form with JS

Status: RESOLVED DUPLICATE of bug 1658082

(Core :: DOM: Forms, defect)

Description

[bartosz.nowotny]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:79.0) Gecko/20100101 Firefox/79.0

Steps to reproduce:

I noticed a regression in Firefox on the webpage I'm maintaining. We have a simple JS multiple form submission prevention mechanism. Recently, I noticed that in Firefox (other browsers still work) the button value is not POSTed. If I remove the JS script that prevents multiple submission, the button value is POSTed correctly. See repro here: https://jsfiddle.net/70ha4ju5/

Actual results:

The form was POSTed to server without the button value.

Expected results:

The form should be POSTed to server with the button value.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[Jason Orendorff [:jorendorff]]

Confirmed that this happens. Maybe disabled controls aren't sent in the POST request? Anyway, not a JS engine issue; DOM folks probably know what's going on here.

Comment 3

[Jason Orendorff [:jorendorff]]

To me, it looks like the spec says to skip it (step 5.1 bullet 2).

Comment 4

[Edgar Chen [:edgar]]

16:32.78 INFO: Last good revision: 4eeda6c8d8c5de4d6f512a9b543e06823098e58e
16:32.78 INFO: First bad revision: 5431d962a10f33df15f35bc47e62b6740b61308e
16:32.78 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=4eeda6c8d8c5de4d6f512a9b543e06823098e58e&tochange=5431d962a10f33df15f35bc47e62b6740b61308e

Comment 5

[Edgar Chen [:edgar]]

Okay, looks like a regression of bug 1590762, but was not able to reproduce on recent Nightly, might be fixed by bug 1658082.
I will run mozregression again with --find-fix.

Comment 6

[Edgar Chen [:edgar]]

13:27.73 INFO: First good revision: 59aaa4311b3a2a13683492d15a52b740aae81879
13:27.73 INFO: Last bad revision: 971e2d1a6140181ce640947ee0288ccc9fd89e6f
13:27.73 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=971e2d1a6140181ce640947ee0288ccc9fd89e6f&tochange=59aaa4311b3a2a13683492d15a52b740aae81879