1660798 - Convert parser code to use const ParserAtom* from JSAtom*

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P1)

Description

[Kannan Vijayan [:djvj]]

This is a sub-bug to capture the massive rename/conversion patch for the parser-atom migration.

Most of this has been posted and updated in the dependent (bug 1592105), but is being landed under this bug for organization purposes.

Comment 1

[Kannan Vijayan [:djvj]]

Attachment: Bug 1660798 - Part 1 - Adaptor glue to allow for parser to transition to internal atoms representation. r?mgaudet,tcampbell

Comment 2

[Kannan Vijayan [:djvj]]

Attachment: Bug 1660798 - Part 2 - Convert uses of JSAtom* and PropertyName* to ParserAtomId and ParserNameId. r?mgaudet,tcampbell

Comment 3

[Kannan Vijayan [:djvj]]

Attachment: Bug 1660798 - Part 1 - Adaptor glue to allow for parser to transition to internal atoms representation. r?mgaudet,tcampbell

Comment 4

[Kannan Vijayan [:djvj]]

Attachment: Bug 1660798 - Part 2 - Convert uses of JSAtom* and PropertyName* to ParserAtomId and ParserNameId. r?mgaudet,tcampbell

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/12d099efac67
Part 1 - Adaptor glue to allow for parser to transition to internal atoms representation. r=mgaudet,tcampbell
https://hg.mozilla.org/integration/autoland/rev/846f88debca6
Part 2 - Convert uses of JSAtom* and PropertyName* to ParserAtomId and ParserNameId. r=tcampbell

Comment 6

[Cosmin Sabou [:CosminS]]

Backed out for causing memory leaks.

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception&revision=846f88debca60ea217616fdc792a1585aa98f40f&failure_classification_id=2&selectedTaskRun=FcXrknANRGqzEuuj3kXRTw.0

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=313890175&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/1a89b886cba63ac6b2647350a41e1a94aa4feb11

Comment 7

[Tooru Fujisawa [:arai]]

Attachment: Bug 1660798 - Part 3 - Release WellKnownParserAtoms in GCRuntime::finishRoots. r?tcampbell!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2258849b0ee1
Part 1 - Adaptor glue to allow for parser to transition to internal atoms representation. r=mgaudet,tcampbell
https://hg.mozilla.org/integration/autoland/rev/e87bcd8a1f94
Part 2 - Convert uses of JSAtom* and PropertyName* to ParserAtomId and ParserNameId. r=tcampbell

Comment 9

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/2258849b0ee1
https://hg.mozilla.org/mozilla-central/rev/e87bcd8a1f94

Comment 10

[Florin Strugariu [:Bebe]]

== Change summary for alert #26805 (as of Fri, 28 Aug 2020 03:58:53 GMT) ==

Regressions:

4% Base Content Heap Unclassified windows10-64-shippable opt 1,496,656.00 -> 1,549,284.00

Improvements:

2% Base Content JS windows7-32-shippable opt 2,715,100.00 -> 2,666,001.33
1% Base Content JS macosx1014-64-shippable opt 3,492,022.00 -> 3,451,670.67
1% Base Content JS linux1804-64-shippable opt 3,486,957.33 -> 3,447,713.33
1% Base Content JS windows10-64-shippable-qr opt 3,491,781.33 -> 3,452,474.67
1% Base Content JS linux1804-64-shippable-qr opt 3,486,930.67 -> 3,447,713.33
1% Base Content JS windows10-64-shippable opt 3,564,864.67 -> 3,524,804.00

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=26805

Comment 11

[Ted Campbell [:tcampbell]]

The change in heap-unclassified is because we did not add accounting for the WellKnownParserAtoms table. With the small base-content JS improvement this comes out as memory neutral (add 50kB, save 50 kB).