Closed Bug 1660853 Opened 3 years ago Closed 3 years ago

Private method initializers fail during JIT compilation

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
82 Branch
Tracking Flags:
Tracking Status
firefox82 --- fixed

People

(Reporter: avandolder, Assigned: avandolder)

References

Details

Attachments

(1 file)

Bug 1660853 - Make sure to empty stack in private method initializers. r?jorendorff
47 bytes, text/x-phabricator-request
Details | Review

Calling mach run --enable-private-fields --enable-private-methods --baseline-eager -e "class A { #p() {} m() { this.#p(); } }; new A().m()" currently fails with Assertion failure: stackDepth() == depth, at js/src/jit/BaselineFrameInfo.h:273. This seems to be due to private methods initializers returning without clearing out the stack.

Pushed by avandolder@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b101041d60c8
Make sure to empty stack in private method initializers. r=jorendorff

https://hg.mozilla.org/mozilla-central/rev/b101041d60c8

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox82: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch
You need to log in before you can comment on or make changes to this bug.