1660861 - Make nsIPrintSettings.clone() not crash on macOS

Status: RESOLVED FIXED

(Core :: Printing: Setup, defect, P1)

Description

[Jonathan Watt [:jwatt]]

As noted in bug 1660527 comment 6:

nsPrintSettingsX::nsPrintSettingsX(const nsPrintSettingsX& src) { *this = src; }

is broken since nsPrintSettingsX::operator=(const nsPrintSettingsX& rhs) can't be called on an uninitialized object since it calls [mPrintInfo release].

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: Bug 1660861. Make nsIPrintSettings.clone() not crash on macOS. r=emilio

Comment 2

[Jonathan Watt [:jwatt]]

Comment on attachment 9171768 [details]
Bug 1660861. Make nsIPrintSettings.clone() not crash on macOS. r=emilio

Beta/Release Uplift Approval Request

• User impact if declined: Print project blocker
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Simple crash fix for code that will only be exercised once new frontend code is added to use it.
• String changes made/needed:

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4f7e328f6ad5
Make nsIPrintSettings.clone() not crash on macOS. r=emilio

Comment 4

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/4f7e328f6ad5

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9171768 [details]
Bug 1660861. Make nsIPrintSettings.clone() not crash on macOS. r=emilio

Approved for 81.0b2.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/403a9033f3ff