Verify whether crash reporter is catching and reporting Fission subframe crashes
Categories
(Toolkit :: Crash Reporting, task, P3)
Tracking
()
Fission Milestone | M6b |
Tracking | Status | |
---|---|---|
firefox-esr68 | --- | unaffected |
firefox-esr78 | --- | unaffected |
firefox79 | --- | unaffected |
firefox80 | --- | unaffected |
firefox81 | --- | unaffected |
firefox82 | --- | affected |
People
(Reporter: cpeterson, Assigned: gsvelto)
References
Details
Before we redesign the crash reporter UX (bug 1644911) to handle subframe crashes, a Fission engineer should verify what the crash reporter currently does with subframe crashes.
- Are they ignored?
- Do they get auto-submitted if the user has checked the "Allow Nightly to send backlogged crash reports on your behalf" setting?
- Does the user get prompted to submit subframe crash reports when Firefox checks for unsubmitted crash reports 10 minutes after Firefox launch? gsvelto says forcing an unsubmitted crash report check can be done in chrome code by calling
UnsubmittedCrashHandler.scheduleCheckForUnsubmittedCrashReports()
.
Updated•4 years ago
|
Comment 1•4 years ago
|
||
I don't really know how I'd go about checking this, so clearing my ni?
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 3•4 years ago
|
||
I verified that crash generation and crash reporting work correctly, here's my test:
- On my local build I enabled fission, restarted the browser then opened a page with a bunch of sub-frames
- I went into
about:processes
and found the PID for one of the sub-frame processes - I killed said process with
SIGABRT
- Once this was done I verified that the crash report had been correctly generated, I restarted Firefox and verified that it was picked up by the standard unsubmitted crash report scan. I even ran our usual tools on the minidump to check its consistency and everything as fine.
Chris is this enough?
Reporter | ||
Comment 4•4 years ago
|
||
(In reply to Gabriele Svelto [:gsvelto] (PTO until September 5th) from comment #3)
I verified that crash generation and crash reporting work correctly, here's my test:
...
- Once this was done I verified that the crash report had been correctly generated, I restarted Firefox and verified that it was picked up by the standard unsubmitted crash report scan. I even ran our usual tools on the minidump to check its consistency and everything as fine.
Chris is this enough?
Yes. Thanks for verifying!
That the subframe crash reports are picked up by the unsubmitted crash report scan is good news. We would still like to improve the crash reporter UX to submit subframe crash reports when they happen (bug 1644911), but given your findings here, that UX work doesn't need to block our Fission Nightly experiment.
Description
•