1660895 - Browser toolbox fail opening with "watchTargets can't access property 'browsingContext', windowGlobal is null" exception

Status: RESOLVED FIXED

(DevTools :: Framework, defect)

Description

[Alexandre Poirot [:ochameau]]

It looks like in the following code, we may process a BrowsingContext in process of creation or destruction, which doesn't have a WindowGlobal currently associated.
https://searchfox.org/mozilla-central/rev/19c23d725f27d0989e4a60f36d64004cebb39736/devtools/server/actors/watcher/target-helpers/frame-helper.js#179-188

  return getAllRemoteBrowsingContexts(
    browserElement?.browsingContext
  ).filter(browsingContext =>
    shouldNotifyWindowGlobal(
      browsingContext.currentWindowGlobal,
      browserElement?.browserId
    )
  );

And so, browsingContext.currentWindowGlobal ends up being null.

console.error: "Error while calling actor 'watcher's method 'watchTargets'" "can't access property \"browsingContext\", windowGlobal is null"
console.error: "shouldNotifyWindowGlobal@resource://devtools/server/actors/watcher/target-helpers/frame-helper.js:254:27\ngetFilteredRemoteBrowsingContext/<@resource://devtools/server/actors/watcher/target-helpers/frame-helper.js:183:29\ngetFilteredRemoteBrowsingContext@resource://devtools/server/actors/watcher/target-helpers/frame-helper.js:182:5\ncreateTargets@resource://devtools/server/actors/watcher/target-helpers/frame-helper.js:25:60\nwatchTargets@resource://devtools/server/actors/watcher.js:138:30\nhandler@resource://devtools/shared/protocol/Actor.js:166:37\nonPacket@resource://devtools/server/devtools-server-connection.js:379:58\n_onJSONObjectReady/<@resource://devtools/shared/transport/transport.js:464:22\nexports.makeInfallible/<@resource://devtools/shared/ThreadSafeDevToolsUtils.js:103:22\nexports.makeInfallible/<@resource://devtools/shared/ThreadSafeDevToolsUtils.js:103:22\n"

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1660895 - Eagerly ignore loading or destroying documents.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/def80b3ac3f6
Eagerly ignore loading or destroying documents. r=nchevobbe

Comment 3

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/def80b3ac3f6