Closed Bug 1660989 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 25224 - [fetch] Empty destination should be the empty string, not "empty"

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox82 fixed)

Status:
RESOLVED FIXED
Milestone:
82 Branch
Tracking Flags:
Tracking Status
firefox82 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 25224 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/25224
Details from upstream follow.

Yutaka Hirano <yhirano@chromium.org> wrote:

[fetch] Empty destination should be the empty string, not "empty"

As specified at [1],the empty destination should be the empty string,
not "empty". We use "empty" for the "sec-fetch-dest" header[2] though.

Fix the implementation and fix incorrect WPTs altogether.

1: https://fetch.spec.whatwg.org/#concept-request-destination
2: https://w3c.github.io/webappsec-fetch-metadata/#abstract-opdef-set-dest

Bug: 1121493
Change-Id: Ia86d716dd434c3b6b0e6f1914019fd6110a7ab8d

Reviewed-on: https://chromium-review.googlesource.com/2374725
WPT-Export-Revision: f7e56a37bf9a85cc6c0849eb53ef8808d6b414df

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 20 subtests

Status Summary

Firefox

OK : 2
PASS : 81
FAIL : 2

Chrome

OK : 2
PASS : 66
FAIL : 17

Safari

OK : 1
PASS : 79
FAIL : 4
ERROR: 1

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/fetch/api/request/request-structure.html
Check isReloadNavigation attribute: FAIL (Chrome: FAIL, Safari: FAIL)
Check isHistoryNavigation attribute: FAIL (Chrome: PASS, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/297fa703c5ef
[wpt PR 25224] - [fetch] Empty destination should be the empty string, not "empty", a=testonly
https://hg.mozilla.org/integration/autoland/rev/12c91a3a36d4
[wpt PR 25224] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/297fa703c5ef
https://hg.mozilla.org/mozilla-central/rev/12c91a3a36d4

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox82: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch
You need to log in before you can comment on or make changes to this bug.