Option to save logins does not keep state in private mode
Categories
(Firefox :: Settings UI, defect, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr68 | --- | unaffected |
firefox-esr78 | --- | unaffected |
firefox79 | --- | unaffected |
firefox80 | --- | unaffected |
firefox81 | --- | wontfix |
firefox82 | --- | verified |
People
(Reporter: mberlinger, Assigned: tgiles)
References
(Regression)
Details
(Keywords: regression)
Attachments
(2 files)
Suggested severity
- S2
Affected versions
- 81.0b1
- 82.0a1 (2020-08-24)
Affected platforms
- Windows 10x64
- mac OS 10.12
- Ubuntu 18.04
- Windows 7x32
Steps to reproduce
- Launch Firefox.
- Access the "about:preferences#privacy"
- Select the "Use custom settings for history" option from the History dropdown list.
- Check the "Always use private browsing mode" checkbox
- Select the "Restart Firefox now" option.
- Access the "about:preferences#privacy" page.
Expected result
- The "Ask to save logins and passwords for websites" checkbox from the Logins & Passwords sections is displayed as unchecked and locked.
Actual result
- The "Ask to save logins and passwords for websites" checkbox from the Logins & Passwords sections is displayed as unchecked and is not locked.
Regression range
- This is a recent regression since I wasn’t able to reproduce it on Firefox 80.0. I’ll come with a regression range asap.
Additional notes
- See the attached screen record with the issue.
- After checking and then unchecking again the option becomes locked.
Comment 1•4 years ago
|
||
To reproduce the problem, I had to go to [Menu] > [Options] > [Privacy & Security] in order at step 6.
i.e. Not visit to "about:preferences#privacy" page directly at step 6.
Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=7940bff128858ebf0c533bed4e41ff3b47bc99be&tochange=3d32e55b4741d14a371a4cc7ca78ad26532f5af1
Updated•4 years ago
|
Comment 2•4 years ago
|
||
[Tracking Requested - why for this release]: User-facing regression on a common preference
Updated•4 years ago
|
Comment 3•4 years ago
|
||
I think this is an edge case so removing the tracking flag. I discussed with tgiles that we probably shouldn't even disable the checkbox at all for permanent private browsing.
Assignee | ||
Comment 4•4 years ago
|
||
This is a holdover from a previous bug and this old behavior should be removed. A user should be able to use the password manager in permanent private browsing.
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 5•4 years ago
|
||
Updated•4 years ago
|
Updated•4 years ago
|
Updated•4 years ago
|
Updated•4 years ago
|
Pushed by mozilla@noorenberghe.ca: https://hg.mozilla.org/integration/autoland/rev/d67d3463b4aa Don't disable the password manager checkbox in permanent private browsing mode. r=MattN,preferences-reviewers,ntim
Comment 7•4 years ago
|
||
bugherder |
Comment 8•4 years ago
|
||
Did you want to nominate this patch for Beta approval?
Comment 9•4 years ago
|
||
Reproducible on latest Nightly 82.0a1 (3020-08-31)(64-bit) on Windows 10
Assignee | ||
Comment 10•4 years ago
|
||
I don't believe this patch needs to be nominated for Beta, but I'll double check and make sure.
Assignee | ||
Updated•4 years ago
|
Comment 11•4 years ago
|
||
Tom, can you please confirm that the full functionality for password manager #preferences should be enabled hence forth with this fix for private mode?
Assignee | ||
Comment 12•4 years ago
|
||
Adrian, this is correct. A user should be able to enable and disable the password manager when in permanent private browsing mode with this fix.
Comment 13•4 years ago
|
||
Should the Exceptions set up in Private Browsing mode remain set up after switching to Normal browsing mode? For other features that have the exceptions list, (such as audio:video) exceptions set up in Private Mode are not saved to normal browsing mode AFAIK.
Assignee | ||
Comment 14•4 years ago
|
||
Should the Exceptions set up in Private Browsing mode remain set up after switching to Normal browsing mode?
I don't know, but I'm assuming that exceptions set up in Private Browsing should not remain when switching back to Normal browsing. The persistence of the Exceptions should not be changed with my patch.
Comment 15•4 years ago
|
||
I have reproduced this issue using Firefox 82.0a1 (2020-08-24) on Win 8.1 x64.
I can confirm this issue is fixed, I verified using Firefox 82.0a1 latest nightly on Win 8.1 x64, macOS 10.15 and Ubuntu 18.04 x64.
Description
•