1661000 - Don't canonize url immediately after a paste

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[Marco Bonardo [:mak]]

I've seen various reports of users pressing Enter after a CTRL+V, while they still keep CTRL pressed. This causes us to canonize the word (adding www. and .com to it) and we end up visiting a non-existing page instead of searching for the pasted word.

To prevent this, we could skip canonization if it happens at a short time after a paste.

Comment 1

[Asif Youssuff]

How short? This really feels like mystery meat navigation - software really shouldn't do magical behaviors that result in inconsistent behaviors with the same user actions.

Comment 2

[Marco Bonardo [:mak]]

(In reply to Asif Youssuff from comment #1)

How short? This really feels like mystery meat navigation - software really shouldn't do magical behaviors that result in inconsistent behaviors with the same user actions.

In general I agree, but I've seen quite a few reports, so it's clear this is an annoyance for users, and canonization is a completely undiscoverable feature, so it's hard for the user to understand what's up.
We could probably check for a CTRL keyup after CTRL+V, if it didn't happen and Enter is pressed before 100ms elapsed, assume the user meant to search. CTRL+V and then CTRL+Enter would still canonize reliably. CTRL+V+Enter not.

Comment 3

[Marco Bonardo [:mak]]

interestingly enough, also Chrome has canonization, what they seem to do is just to check for a ctrl keyup, so we could just do the same and be consistent with them.

Comment 4

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1661000: Avoid urlbar search string canonization if ctrl key comes from a previous action.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4c449cde60a7
Avoid urlbar search string canonization if ctrl key comes from a previous action. r=mak

Comment 7

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/4c449cde60a7