1661006 - Some password manager tests fail intermittently because the 'passwordmgr-processed-form' notification is delayed.

Status: RESOLVED FIXED

(Toolkit :: Password Manager, defect, P1)

Description

[Neil Deakin]

The tests run 'registerRunTests' which sets up a fake form with the id 'observerforcer', then waits for the observer notification that the password manager has processed the form. This is happening at https://searchfox.org/mozilla-central/rev/62f6cc5d9c829bc0c6f18e25f93203a98681ac97/toolkit/components/passwordmgr/test/mochitest/pwmgr_common.js#335

Some tests already have one or more forms within the test. For example, the test 'test_autocomplete_password_generation.html' has three forms in it. These also send form processed notifications on load, however, as far as I can tell, nothing waits for these notifications. The test only waits for the 'observerforcer' notification.

This sometimes leads to the notifications being sent significantly later during the test, causing confusion and failures.

Comment 1

[Neil Deakin]

Attachment: Bug 1661006, have registerRunTests wait for notifications from all password fields on the test page before continuing, r=MattN

Depends on D87150

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6b76b0979ffb
have registerRunTests wait for notifications from all password fields on the test page before continuing, r=MattN

Comment 3

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/6b76b0979ffb