Closed Bug 1661026 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 25229 - [scroll-animations] Support animation-timeline:none

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox82 fixed)

Status:
RESOLVED FIXED
Milestone:
82 Branch
Tracking Flags:
Tracking Status
firefox82 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 25229 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/25229
Details from upstream follow.

Anders Hartvoll Ruud <andruud@chromium.org> wrote:

[scroll-animations] Support animation-timeline:none

Parsing of the 'none' keyword was already supported, so this CL
simply connects the dots between the parsed timeline name
and the timeline we pass to the CSSAnimation.

For the InertEffect, the inherited_time now needs to be a base::nullopt
to prevent an effect value from being produced, so a small adjustment
was needed there.

Note: Changing from IsScrollTimeline() to IsMonotonicallyIncreasing()
is just a cosmetic change.

Note also that the test animation-timeline-in-keyframe.html required
a small adjustment: previously, the computed value of animation-timeline
was 'bar', but there was no @scroll-timeline corresponding to 'bar',
so according to spec the animation has no timeline in this case,
and therefore no effect value [1]. We previously fell back
to the DocumentTimeline, which is not correct: we should have fallen
back to "no timeline", which is what we do as of this CL.

[1] https://drafts.csswg.org/css-animations-2/#animation-timeline

Bug: 1074052, 1097046
Change-Id: Ia664f92f70dff68a17eb82315d6bb7bf18de79f8
Reviewed-on: https://chromium-review.googlesource.com/2367835
WPT-Export-Revision: 7e99e24dd22984be2142d64e52ac0bd38d6be054

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 2 subtests

Status Summary

Firefox

OK : 2
FAIL: 3

Chrome

OK : 2
FAIL: 3

Safari

OK : 2
FAIL: 3

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/scroll-animations/css/animation-timeline-in-keyframe.html
The animation-timeline property may not be used in keyframes: FAIL (Chrome: FAIL, Safari: FAIL)
/scroll-animations/css/animation-timeline-none.html
Animation with unknown timeline name has no effect value: FAIL (Chrome: FAIL, Safari: FAIL)
Animation with animation-timeline:none has no effect value: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9511399fbc48
[wpt PR 25229] - [scroll-animations] Support animation-timeline:none, a=testonly

https://hg.mozilla.org/mozilla-central/rev/9511399fbc48

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox82: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch
Regressions: 1661603
You need to log in before you can comment on or make changes to this bug.