Closed Bug 1661086 Opened 1 year ago Closed 1 year ago

Move guessed JSFunction name initialization to same place as ObjectGroup update

Categories

(Core :: JavaScript Engine, task, P1)

task

Tracking

()

RESOLVED FIXED
82 Branch
Tracking Status
firefox82 --- fixed

People

(Reporter: tcampbell, Assigned: tcampbell)

References

Details

Attachments

(1 file)

With Bug 1660798, updating the function name will become fallible so we can no longer do this in UpdateEmittedInnerFunctions. Instead it makes sense to move to SetTypeForExposedFunctions where we apply ObjectGroup changes and may OOM in process.

Overall these sets of updates should be better organized since they all reflect the same sort of update-JSFunction-with-new-info-derived-from-compiling-enclosing-script.

This is needed since updating the function name will soon be fallible which
is not allowed in UpdateEmittedInnerFunctions. Move the name updates to the
same place that ObjectGroup updates happen which suffer the same OOM issue.
If an OOM occurs here during delazification, the next attempt at recompile
will compute the same name. Applying the name update early is not a problem
and is what the frontend previously did before stencil.

Pushed by tcampbell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/67ca0e7de754
Update function guessed names when updating ObjectGroup. r=mgaudet
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch
You need to log in before you can comment on or make changes to this bug.