Closed Bug 1661096 Opened 4 years ago Closed 4 years ago

IOUtils build does not allow system NSPR

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
82 Branch
Tracking Flags:
Tracking Status
firefox-esr68 --- unaffected
firefox-esr78 --- unaffected
firefox80 --- wontfix
firefox81 --- fixed
firefox82 --- fixed

People

(Reporter: wolfiR, Assigned: barret)

Details

Attachments

(2 files)

mozilla-system-nspr.patch
1.51 KB, patch
Details | Diff | Splinter Review
Bug 1661096 - Support system NSPR in IOUtils r?gijs
47 bytes, text/x-phabricator-request
RyanVM
: approval-mozilla-release+
Details | Review

Starting with FF80 (and apparently up to mozilla-central) dom/system/IOUtils* fails to build with system provided NSPR.
Possible fix attached.

Severity: -- → S3
status-firefox80: --- → wontfix
status-firefox81: --- → affected
status-firefox-esr68: --- → unaffected
status-firefox-esr78: --- → unaffected
Flags: needinfo?(krourke)
Flags: needinfo?(mail) → needinfo?(brennie)
Assignee: nobody → brennie
Flags: needinfo?(brennie)
Pushed by brennie@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3fd1c3e9d164
Support system NSPR in IOUtils r=Gijs

https://hg.mozilla.org/mozilla-central/rev/3fd1c3e9d164

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox82: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch

The patch landed in nightly and beta is affected.
:barret, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Flags: needinfo?(brennie)

Comment on attachment 9174991 [details]
Bug 1661096 - Support system NSPR in IOUtils r?gijs

Beta/Release Uplift Approval Request

  • User impact if declined: This does not affect end users, only those building Firefox (e.g. Linux distributions) who use system nspr. Including this will make things easier for package maintainers.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): This just updates some header includes to enable system nspr builds.
  • String changes made/needed:
Flags: needinfo?(brennie)
Attachment #9174991 - Flags: approval-mozilla-beta?

Comment on attachment 9174991 [details]
Bug 1661096 - Support system NSPR in IOUtils r?gijs

Approved for 81.0rc1.

Attachment #9174991 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Attachment #9174991 - Flags: approval-mozilla-beta+ → approval-mozilla-release+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: