1661134 - Lando's DONTBUILD button shouldn't show up if the commit message already has DONTBUILD in it (or should be pre-checked?)

Status: RESOLVED FIXED

(Conduit :: Lando, defect, P3)

Description

[Matthew Gaudet (he/him) [:mgaudet]]

Just landed this with DONTBUILD DONTBUILD as I wasn't entirely clear on what the checkmark would do.

Turns out: Double-Don't-build :)

(super minor issue)

Comment 1

[Daniel Holbert [:dholbert]]

Ideally I would expect that we should:
(1) detect that DONTBUILD is already present in the commit message, and if so:
(2) mark the DONTBUILD checkbox as checked & disabled, like so:

data:text/html,<input type="checkbox" checked disabled>

Comment 2

[Zeid [:zeid]]

Attachment: GitHub Pull Request

Comment 3

[Zeid [:zeid]]

(In reply to Daniel Holbert [:dholbert] from comment #1)

Ideally I would expect that we should:
(1) detect that DONTBUILD is already present in the commit message, and if so:
(2) mark the DONTBUILD checkbox as checked & disabled, like so:

data:text/html,<input type="checkbox" checked disabled>

That's the fix that I implemented, it's not deployed yet though.