Remove _ensure_zstd()
Categories
(Firefox Build System :: General, task)
Tracking
(firefox85 fixed)
Tracking | Status | |
---|---|---|
firefox85 | --- | fixed |
People
(Reporter: rstewart, Assigned: mhentges)
References
Details
Attachments
(1 file)
This is no longer necessary after bug 1656993.
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Comment 1•3 years ago
|
||
The zstandard package is always installed in the mach virtualenv.
The patch assumes that zstandard is only used from the mach virtualenv,
and never the build virtualenv.
Pushed by mhentges@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f1d785de7ab3 Removes _ensure_zstd() and usages r=firefox-build-system-reviewers,glandium
Comment 3•3 years ago
|
||
bugherder |
Backout by csabou@mozilla.com: https://hg.mozilla.org/mozilla-central/rev/40509c4eae51 Backed out changeset f1d785de7ab3 for causing symbols bustages. a=backout.
Updated•3 years ago
|
Comment 5•3 years ago
|
||
Backed out for causing symbols bustages.
Failure log: https://treeherder.mozilla.org/logviewer?job_id=323363113&repo=mozilla-central
Backout link: https://hg.mozilla.org/mozilla-central/rev/40509c4eae511676e50963f1e3169f0f4d359581
Updated•3 years ago
|
Assignee | ||
Comment 6•3 years ago
|
||
The patch assumes that zstandard is only used from the mach virtualenv,
and never the build virtualenv.
Welp, the premise of this patch was proven false!
I'll remove most usages, but keep the upload_symbols.py
one :)
There's work needed to make package handling more consistent, but that's a job for the future!
Pushed by mhentges@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2da7a091b64b Removes _ensure_zstd() and usages r=firefox-build-system-reviewers,glandium
Comment 8•3 years ago
|
||
bugherder |
Description
•