Closed Bug 1661153 Opened 4 years ago Closed 3 years ago

Remove _ensure_zstd()

Categories

(Firefox Build System :: General, task)

task

Tracking

(firefox85 fixed)

RESOLVED FIXED
85 Branch
Tracking Status
firefox85 --- fixed

People

(Reporter: rstewart, Assigned: mhentges)

References

Details

Attachments

(1 file)

This is no longer necessary after bug 1656993.

Assignee: rstewart → nobody
Assignee: nobody → mhentges

The zstandard package is always installed in the mach virtualenv.
The patch assumes that zstandard is only used from the mach virtualenv,
and never the build virtualenv.

Pushed by mhentges@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f1d785de7ab3
Removes _ensure_zstd() and usages r=firefox-build-system-reviewers,glandium
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 85 Branch
Backout by csabou@mozilla.com:
https://hg.mozilla.org/mozilla-central/rev/40509c4eae51
Backed out changeset f1d785de7ab3 for causing symbols bustages. a=backout.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Flags: needinfo?(mhentges)

The patch assumes that zstandard is only used from the mach virtualenv,
and never the build virtualenv.

Welp, the premise of this patch was proven false!
I'll remove most usages, but keep the upload_symbols.py one :)

There's work needed to make package handling more consistent, but that's a job for the future!

Flags: needinfo?(mhentges)
Pushed by mhentges@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2da7a091b64b
Removes _ensure_zstd() and usages r=firefox-build-system-reviewers,glandium
Status: REOPENED → RESOLVED
Closed: 3 years ago3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 85 Branch
Regressions: 1680675
See Also: → 1681569
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: