Closed Bug 1661155 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 25237 - [css-grid] Set available column space before grid items prelayout

Categories

(Core :: Layout: Grid, task, P4)

Product:
Core
Component:
Layout: Grid
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
82 Branch
Tracking Flags:
Tracking Status
firefox82 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 25237 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/25237
Details from upstream follow.

Oriol Brufau <obrufau@igalia.com> wrote:

[css-grid] Set available column space before grid items prelayout

Before running the grid track sizing algorithm, there is a prelayout
step which takes care of the baseline alignment of the items.
In order to do that, we estimate the size of the grid area, since we
have not calculated the final size yet.

The problem was that, when calculating this estimate, the available
column space had not been set yet. So if a column had a percentage track
sizing function, it would be treated as auto and the estimated size
would be wrong.

This patch sets the available column space so that we can resolve
percentage track sizing functions and get a more correct estimate.

Bug: 1121761

TEST=external/wpt/css/css-grid/alignment/self-baseline/grid-self-baseline-008.html

Change-Id: Ic4410b0a80b92afa5adfd62187ec236bd4fd3ba0
Reviewed-on: https://chromium-review.googlesource.com/2375649
WPT-Export-Revision: 6512edf01ea36bd70ffc058bddf65178ad364c87

Component: web-platform-tests → Layout: Grid
Product: Testing → Core

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

FAIL: 1

Chrome

FAIL: 1

Safari

FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-grid/alignment/self-baseline/grid-self-baseline-008.html: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0a7aeef6d2ec
[wpt PR 25237] - [css-grid] Set available column space before grid items prelayout, a=testonly
https://hg.mozilla.org/integration/autoland/rev/c447b91b04f8
[wpt PR 25237] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/0a7aeef6d2ec
https://hg.mozilla.org/mozilla-central/rev/c447b91b04f8

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox82: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch
You need to log in before you can comment on or make changes to this bug.