1661211 - Warp: transpile getter/setter calls

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, task, P2)

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Bug 1661211 part 1 - Clean up CacheIR ops for getter calls. r?iain!

We had different CacheIR ops for receiver-is-object and receiver-is-Value. This
patch unifies them by always using the receiver-is-Value version. This makes it
easier to transpile in Warp.

When generating CacheIR, pass and use the receiverId (Value) in a few places
instead of objId. This also lets us support non-object receivers for super.prop

There are two places where this doesn't work and boxObject is used to convert
from object-id to value-id. In the future this could be a dedicated CacheIR op
instead of a cast, but that would require BaselineInspector changes.

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Bug 1661211 part 2 - Store nargsAndFlags for getter calls. r?iain!

This is for use by the transpiler, similar to GuardSpecificFunction.

Depends on D88264

Comment 3

[Jan de Mooij [:jandem]]

Attachment: Bug 1661211 part 3 - Add sameRealm flag to CallNativeGetterResult. r?iain!

Depends on D88265

Comment 4

[Jan de Mooij [:jandem]]

Attachment: Bug 1661211 part 4 - Transpile getter calls. r?iain!

We can reuse most of the code in maybeCallTarget for creating a WrappedFunction
from callee/nargs/flags, so that was factored out as a helper function.

Instead of the "stack spoofing" that IonBuilder does (see ensureHasSlots call),
add initForGetterCall to CallInfo so we can set callee/thisv directly.

Depends on D88266

Comment 5

[Jan de Mooij [:jandem]]

Attachment: Bug 1661211 part 5 - CacheIR changes preparing for transpiling setter calls. r?iain!

Add nargsAndFlags, add sameRealm flag to CallNativeSetter.

Depends on D88267

Comment 6

[Jan de Mooij [:jandem]]

Attachment: Bug 1661211 part 6 - Transpile setter calls. r?iain!

Again similar to the IonBuilder code but without the stack spoofing.

IonBuilder uses BytecodeIsPopped(pc) for ignoresReturnValue but the return value
of a setter is never used so we can just pass true.

Depends on D88268

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fc681a8e552e
part 1 - Clean up CacheIR ops for getter calls. r=iain
https://hg.mozilla.org/integration/autoland/rev/d01415c7707e
part 2 - Store nargsAndFlags for getter calls. r=iain
https://hg.mozilla.org/integration/autoland/rev/e25e289e016c
part 3 - Add sameRealm flag to CallNativeGetterResult. r=iain
https://hg.mozilla.org/integration/autoland/rev/a86d23fda071
part 4 - Transpile getter calls. r=iain
https://hg.mozilla.org/integration/autoland/rev/73140c7a14a4
part 5 - CacheIR changes preparing for transpiling setter calls. r=iain
https://hg.mozilla.org/integration/autoland/rev/04787b6cf6a3
part 6 - Transpile setter calls. r=iain

Comment 8

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/fc681a8e552e
https://hg.mozilla.org/mozilla-central/rev/d01415c7707e
https://hg.mozilla.org/mozilla-central/rev/e25e289e016c
https://hg.mozilla.org/mozilla-central/rev/a86d23fda071
https://hg.mozilla.org/mozilla-central/rev/73140c7a14a4
https://hg.mozilla.org/mozilla-central/rev/04787b6cf6a3