Closed Bug 1661247 Opened 4 years ago Closed 4 years ago

Default display font names are not localized if gfx.e10s.font-list.shared=true

Categories

(Core :: Layout: Text and Fonts, defect)

Desktop
Windows 10
defect

Tracking

()

RESOLVED FIXED
83 Branch
Tracking Status
firefox83 --- fixed

People

(Reporter: alice0775, Assigned: jfkthame)

References

Details

Attachments

(2 files)

Environment: Windows10 Japanese version
Bug 1648474 does not fix display name of default font.

Steps to reproduce:

  1. Set gfx.e10s.font-list.shared to true
  2. about:preferences > Fonts and Colors
  3. Advanced > Select font for "Japanese"

Actual Results:
既定(Yu Mincho),(Meiryo),(MS Gothic) in ja build
Default(Yu Mincho),(Meiryo),(MS Gothic) in en-US build

Expected Results;
既定(游明朝),(メイリオ),(MS ゴシック) in ja build
Default(游明朝),(メイリオ),(MS ゴシック)in en-US build

Jonathan, am I right in thinking this is your area?

Component: Preferences → Layout: Text and Fonts
Flags: needinfo?(jfkthame)
Product: Toolkit → Core
See Also: → 1648474

Hmm, I suspect this may (in the new font-list world) be dependent on which names are used in all.js, which has always used the English rather than Japanese-localized names. Need to think about how we should handle that...

Flags: needinfo?(jfkthame)
Severity: -- → S3
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED

There's a try build at https://treeherder.mozilla.org/#/jobs?repo=try&revision=62b0a5702a12540273a3ab521e3234f8613085fe&selectedTaskRun=WjYTumtDQauDZdEeXWXVbQ.0 with this patch; Alice0775, could you confirm this shows the localized font names as you would expect on your system? Thanks!

Flags: needinfo?(alice0775)

(In reply to Jonathan Kew (:jfkthame) from comment #4)

There's a try build at https://treeherder.mozilla.org/#/jobs?repo=try&revision=62b0a5702a12540273a3ab521e3234f8613085fe&selectedTaskRun=WjYTumtDQauDZdEeXWXVbQ.0 with this patch; Alice0775, could you confirm this shows the localized font names as you would expect on your system? Thanks!

Yes, the try-build works as expected. The issue is no longer reproduced.

Flags: needinfo?(alice0775)
Pushed by jkew@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6122e1a186c4 Implement a LocalizedFamilyName method in the shared font-list, to enable proper localized font name display in the Preferences dialog on Windows. r=jwatt
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: