1661302 - [wpt-sync] Sync PR 25248 - [Sheriff] Revert "[Perfect Negotiation] Surface session descriptions at the right time."

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 25248 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/25248
Details from upstream follow.

Amr Aboelkher <[e-mail]> wrote:

[Sheriff] Revert "[Perfect Negotiation] Surface session descriptions at the right time."

This reverts commit 3bc91ccc927f8eb887a84a1e59f34c88518ce2ab.

Reason for revert: Failure of WebKit Linux ASAN build, and that's the suspect for root cause. See https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20ASAN/17329

Original change's description:

[Perfect Negotiation] Surface session descriptions at the right time.

This fixes another timing related issue that blocks Perfect Negotiation.

Before this CL, current/pending local/remote description attributes do
blocking-invokes on the webrtc thread, fetching the most up-to-date
states. This can prematurely expose the result of "in-parallel"
operations that have not surfaced yet, such as:

• setLocalDescription
• setRemoteDescription
• addIceCandidate

This CL fixes that by copying the SDP states when any of these
operations complete on the WebRTC thread and carry them over in the
PostTask to the main thread. Here, we store these snapshots in
"internal slots" (variables living on the main thread). With this CL,
reading SDP attributes from RTCPeerConnection is non-blocking and
spec-compliant.

WPT test coverage added for the exact timing of SLD/SRD and other test
expectations are updated. addIceCandidate updating the SDP is already
covered by old WPTs.

Bug: chromium:1110347
Change-Id: Id41ec354465525c6cedf631fe2209fe097148f60
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323359
Commit-Queue: Henrik Boström \<[e-mail]>
Reviewed-by: Harald Alvestrand \<[e-mail]>
Cr-Commit-Position: refs/heads/master@{#801798}

TBR=[e-mail],[e-mail]

Change-Id: I4af12fd1430773ea3d134cfc37b9c5e736f20ed0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1110347
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377715
Reviewed-by: Amr Aboelkher \<[e-mail]>
Commit-Queue: Amr Aboelkher \<[e-mail]>
Cr-Commit-Position: refs/heads/master@{#801822}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 25248 applied with additional changes from upstream: 0d794eb31a9920dd63065a1c4de2d14132b986f5

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=4265ae4fedb9946fb31341408e00a9a935cbd8b4

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Test result changes from PR not available.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b87bfa50cdbe
[wpt PR 25248] - [Sheriff] Revert "[Perfect Negotiation] Surface session descriptions at the right time.", a=testonly

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/b87bfa50cdbe