1661307 - Phabricator emails: Render comments with Remarkup (and style pings)

Status: RESOLVED FIXED

(Conduit :: Phabricator, enhancement, P3)

Description

[Mitchell Hentges [:mhentges] 🦀]

The raw text of Phabricator comments is in markdown. When a user views these comments, they're going to want to see the comments rendered, just like how they'd seem them on Phabricator itself.

Additionally, ensure that pings (e.g.: @mhentges) are styled so it's clear that they are pings. (Perhaps also style them specially if they're pings targeting the current recipient?)

Comment 1

[:glob ✱]

Phabricator doesn't use Markdown, it uses Remarkup instead.

https://secure.phabricator.com/book/phabricator/article/remarkup/

This is a Phabricator specific markup language making this task more than just pointing an off-the-shelf library at the problem 🙁

Comment 2

[Mitchell Hentges [:mhentges] 🦀]

Ah, true, thanks for the correction.
Either way, since this rendering should happen server-side IMHO (within phabricator-extensions), I'm relatively confident that we can just tie into the existing rendering logic, rather than throwing different software at it (that might render differently in unexpected ways).

Comment 3

[Mitchell Hentges [:mhentges] 🦀]

Attachment: Bug 1661307: Adds "asHtml" and "asText" properties to comments

While retaining the existing comment properties for
backwards-compatibility, this patch adds "message" properties to
events with comments and inline comment objects. These "message"
properties contain the comment markup rendered to two different formats
(text and html).

Depends on D91817

Comment 4

[Mitchell Hentges [:mhentges] 🦀]

Attachment: GitHub Pull Request