In about:processes, the `browser` process should display `residentSetSize` rather than `residentUniqueSize`
Categories
(Toolkit :: Performance Monitoring, enhancement, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox84 | --- | fixed |
People
(Reporter: Yoric, Assigned: Yoric)
References
Details
(Keywords: good-first-bug, Whiteboard: [lang=js])
Attachments
(4 files, 1 obsolete file)
In aboutProcesses.js, we currently display the resident-unique size for all processes.
This bug is about making sure that one of the processes uses the resident set size instead.
Steps:
- Rename all the uses of
totalResidentUniqueSize
anddeltaResidentUniqueSize
tototalResidentSize
anddeltaResidentSize
. - Where we define
totalResidentSize
, ifresult.type == "browser"
, instead of usingcur.residentUniqueSize
, usecur.residentSetSize
. - Rebuild Firefox and check that
about:processes
still displays something consistent at the first line!
Assignee | ||
Comment 2•4 years ago
|
||
(In reply to audreykadjar from comment #1)
hello! Can I work on this?
Definitely!
If you have any questions, don't hesitate to ask in https://chat.mozilla.org/#/room/#introduction:mozilla.org . I'm Yoric
on that channel.
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 4•4 years ago
|
||
(In reply to rk28ruchi from comment #3)
Hello, can I work on this issue.?
Definitely!
If you have any questions, don't hesitate to ask in https://chat.mozilla.org/#/room/#introduction:mozilla.org . I'm Yoric on that channel.
Comment 5•4 years ago
|
||
Hello, can I work on this issue?
Comment 6•4 years ago
|
||
Actually, I think I have fixed this issue and submitted my commit using the moz-phab submit command. Kindly check my commit and review.
Comment 7•4 years ago
|
||
Depends on D92491
Comment 8•4 years ago
|
||
Depends on D92564
Updated•4 years ago
|
Comment 9•4 years ago
|
||
Depends on D92565
Updated•4 years ago
|
Updated•4 years ago
|
Updated•4 years ago
|
Comment 10•4 years ago
|
||
Assigning to David as this has been inactive for a while now.
Comment 11•4 years ago
|
||
Assignee | ||
Comment 12•4 years ago
|
||
Since bug 1652813, we have stopped counting shared memory as part of every single process. However, we haven't really counted it as part of any process. With this patch, we count shared memory as part of the parent process.
We also take this opportunity to harmonize the name of the (empty) CSS classes that we use to display memory, as they had distinct names on different rows for no reason.
Assignee | ||
Comment 13•4 years ago
|
||
Comment 14•4 years ago
|
||
Pushed by dteller@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9c53e7ab89de In about:processes, count the cost of shared memory as part of the parent process;r=florian
Comment 15•4 years ago
|
||
bugherder |
Description
•