Closed Bug 1661312 Opened 4 years ago Closed 4 years ago

In about:processes, the `browser` process should display `residentSetSize` rather than `residentUniqueSize`

Categories

(Toolkit :: Performance Monitoring, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
84 Branch
Fission Milestone M7
Tracking Status
firefox84 --- fixed

People

(Reporter: Yoric, Assigned: Yoric)

References

Details

(Keywords: good-first-bug, Whiteboard: [lang=js])

Attachments

(4 files, 1 obsolete file)

In aboutProcesses.js, we currently display the resident-unique size for all processes.

This bug is about making sure that one of the processes uses the resident set size instead.

Steps:

  1. Rename all the uses of totalResidentUniqueSize and deltaResidentUniqueSize to totalResidentSize and deltaResidentSize.
  2. Where we define totalResidentSize, if result.type == "browser", instead of using cur.residentUniqueSize, use cur.residentSetSize.
  3. Rebuild Firefox and check that about:processes still displays something consistent at the first line!

hello! Can I work on this?

Flags: needinfo?(dteller)

(In reply to audreykadjar from comment #1)

hello! Can I work on this?

Definitely!

If you have any questions, don't hesitate to ask in https://chat.mozilla.org/#/room/#introduction:mozilla.org . I'm Yoric on that channel.

Flags: needinfo?(dteller)
Flags: needinfo?(audreykadjar)

Hello, can I work on this issue.?

(In reply to rk28ruchi from comment #3)

Hello, can I work on this issue.?

Definitely!

If you have any questions, don't hesitate to ask in https://chat.mozilla.org/#/room/#introduction:mozilla.org . I'm Yoric on that channel.

Hello, can I work on this issue?

Actually, I think I have fixed this issue and submitted my commit using the moz-phab submit command. Kindly check my commit and review.

Assignee: nobody → ee1190487
Status: NEW → ASSIGNED
Attached file Bug 1661312 fixed.. (obsolete) —

Depends on D92565

Attachment #9179829 - Attachment description: Bug 1661312 fixed → Bug 1661312 - In about:processes, rename `totalResidentUniqueSize` => `totalResidentSize`;r?yoric
Attachment #9179830 - Attachment description: Bug 1661312 fixed. → Bug 1661312 - In about:processes, the browser process now shows the `residentSetSize`;r?yoric
Attachment #9179897 - Attachment is obsolete: true

Assigning to David as this has been inactive for a while now.

Assignee: ee1190487 → dteller
Mentor: dteller
Severity: -- → N/A
Fission Milestone: --- → M7
Flags: needinfo?(audreykadjar)
Priority: -- → P2

Since bug 1652813, we have stopped counting shared memory as part of every single process. However, we haven't really counted it as part of any process. With this patch, we count shared memory as part of the parent process.

We also take this opportunity to harmonize the name of the (empty) CSS classes that we use to display memory, as they had distinct names on different rows for no reason.

Pushed by dteller@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9c53e7ab89de
In about:processes, count the cost of shared memory as part of the parent process;r=florian
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: