1661315 - Perma /web-animations/idlharness.window.html | Animation interface: attribute timeline - assert_equals: setter must be function for PutForwards, Replaceable, or non-readonly attributes expected "function" but got "undefined" for Gecko 82 Beta (20200921)

Status: VERIFIED FIXED

(Core :: DOM: Animation, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

central-as-beta simulation: https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&selectedTaskRun=FJhFVxWVT_65LdZltNtIqw.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=d7e5cdafd76b6603d9877d67e457fb79d6f5941b&searchStr=wpt

Log: https://treeherder.mozilla.org/logviewer.html#?job_id=314084249&repo=try

[task 2020-08-26T13:14:21.033Z] 13:14:21 INFO - TEST-PASS | /web-animations/idlharness.window.html | Animation interface: attribute effect
[task 2020-08-26T13:14:21.033Z] 13:14:21 INFO - TEST-UNEXPECTED-FAIL | /web-animations/idlharness.window.html | Animation interface: attribute timeline - assert_equals: setter must be function for PutForwards, Replaceable, or non-readonly attributes expected "function" but got "undefined"
[task 2020-08-26T13:14:21.033Z] 13:14:21 INFO - IdlInterface.prototype.do_interface_attribute_asserts@http://web-platform.test:8000/resources/idlharness.js:3166:22
[task 2020-08-26T13:14:21.033Z] 13:14:21 INFO - IdlInterface.prototype.test_member_attribute/<@http://web-platform.test:8000/resources/idlharness.js:2399:26
[task 2020-08-26T13:14:21.033Z] 13:14:21 INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1977:25
[task 2020-08-26T13:14:21.033Z] 13:14:21 INFO - IdlInterface.prototype.test_member_attribute@http://web-platform.test:8000/resources/idlharness.js:2334:12
[task 2020-08-26T13:14:21.033Z] 13:14:21 INFO - IdlInterface.prototype.test_members@http://web-platform.test:8000/resources/idlharness.js:2768:22
[task 2020-08-26T13:14:21.033Z] 13:14:21 INFO - IdlInterface.prototype.test@http://web-platform.test:8000/resources/idlharness.js:1603:10
[task 2020-08-26T13:14:21.033Z] 13:14:21 INFO - IdlArray.prototype.test@http://web-platform.test:8000/resources/idlharness.js:906:28
[task 2020-08-26T13:14:21.033Z] 13:14:21 INFO - idl_test/</<@http://web-platform.test:8000/resources/idlharness.js:3568:31
[task 2020-08-26T13:14:21.056Z] 13:14:21 INFO - ................................................................................................
[task 2020-08-26T13:14:21.057Z] 13:14:21 INFO - TEST-OK | /web-animations/idlharness.window.html | took 702ms

https://hg.mozilla.org/mozilla-central/rev/de1a0c42545273ed811bf2fa58253c1352435c5a removed a rule for this to PASS on release_or_beta and to fail on central yesterday.

James, do you have insight about this change? Did the idlharness change?

Comment 1

[Brian Birtles (:birtles, Feb 26~ parental leave)]

I think I might understand what is going on.

Making Animation.timeline mutable, although implemented in Gecko, was originally deferred to Web Animations level 2. We use a build-time flag to disable it (https://searchfox.org/mozilla-central/rev/27932d4e6ebd2f4b8519865dad864c72176e4e3b/dom/webidl/Animation.webidl#27) for all channels except Nightly.

Recently, it was suggested that it be re-added to Web Animations level 1 and the spec was updated.

I believe the IDL tested by idlharness is automatically generated from the spec and hence the test will now be checking that Animation.timeline is mutable but it is only mutable on Nightly, hence why beta started failing.

I suggest this test needs to be marked as failing for non-Nightly.

Comment 2

[Cosmin Sabou [:CosminS]]

Attachment: Bug 1661315 - Set [Animation interface: attribute timeline] to fail on non-nightly builds. r=birtles,jgraham

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/508b69014dd8
Set [Animation interface: attribute timeline] to fail on non-nightly builds. r=birtles DONTBUILD

Comment 4

[Cosmin Sabou [:CosminS]]

Patch verified in beta-sims: https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&resultStatus=success%2Ctestfailed%2Cbusted%2Cexception&author=cbrindusan%40mozilla.com&fromchange=cd682aef68b8eb0a1b4f67b1731ce5db02c89169&searchStr=linux%2C18.04%2Cx64%2Cshippable%2Copt%2Cweb%2Cplatform%2Ctests%2Ctest-linux1804-64-shippable%2Fopt-web-platform-tests-e10s%2Cwpt5&selectedTaskRun=GjrQCv7xRxysGjGhJCs7sA.0

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/508b69014dd8

Comment 6

[Cristina Coroiu [:ccoroiu]]

Verified as fixed with today's beta sim:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e5ae008bd5e734293919c17b1b92034dbb9f254e&searchStr=Linux%2C18.04%2Cx64%2Cshippable%2Copt%2CWeb%2Cplatform%2Ctests%2Ctest-linux1804-64-shippable%2Fopt-web-platform-tests-e10s%2Cwpt5&selectedTaskRun=f2UUZ-8OTVmzd80qOQ3jtw.0