1661338 - Update pdf.js to version 2.6.318

Status: VERIFIED FIXED

(Firefox :: PDF Viewer, task)

Description

[Ryan VanderMeulen [:RyanVM]]

+++ This bug was initially created as a clone of Bug #1660617 +++

Changes since last update:
#12270 Accent positioning in Type1 seac glyphs
#12276 Access the XRef/Catalog data correctly in the "GetStats"/"GetPageIndex" handlers in src/core/worker.js
#12271 Improve AcroForm/XFA form type detection
#12285 Ensure that the sourceEventType parameter is actually optional in PDFViewerApplication.{download, save} (PR 12248 follow-up)
#12286 Use a link, rather than window.open, when opening PDF attachments in Firefox (bug 1661259)

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Try push:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c2b8c457cb2c486ec091e038a77cf41250c7c935

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Attachment: Bug 1661338 - Update pdf.js to version 2.6.318. r=bdahl

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4832d9dbb6fe
Update pdf.js to version 2.6.318. r=bdahl

Comment 4

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/4832d9dbb6fe

Comment 5

[Brendan Dahl [:bdahl]]

Comment on attachment 9172259 [details]
Bug 1661338 - Update pdf.js to version 2.6.318. r=bdahl

Beta/Release Uplift Approval Request

• User impact if declined: - fallback bar button "Open With Different Viewer" will be broken in some cases
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: 1. open https://www.irs.gov/pub/irs-pdf/f1040.pdf

2. click within the PDF (yellow fallback bar should appear below url bar)
3. click "Open With Different Viewer"
4. ensure pdf is launched

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Minor changes to pdf.js that are needed for project shirley.
• String changes made/needed:

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9172259 [details]
Bug 1661338 - Update pdf.js to version 2.6.318. r=bdahl

Approved for 81.0b4.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/259b95b7f2dc

Comment 8

[Cristian Fogel [:cfogel]]

Verified with 81.0b4, 82.0a1 (2020-08-30) on macOS 11.0, Windows 10, Ubuntu 16.

As a double check, noticed that the bar is not displayed on some other link/files; noted in this bug.