1661363 - Clang-11 enforces -Wpointer-to-int-cast

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect)

Description

[Rob Lemley [:rjl]]

-Wpointer-to-int-cast appears to be a new warning/error that is enabled by default in Clang 11. Per the docs, it existed previously for gcc compatibility but had no effect.

It breaks Windows builds though:

/builds/worker/fetches/clang/bin/clang-cl -Xclang -std=c++17 -FonsMessengerWinIntegration.obj -c  -I/builds/worker/workspace/obj-build/dist/stl_wrappers -guard:cf -DNDEBUG=1 -DTRIMMED=1 -DUNICODE -D_UNICODE -D_CRT_RAND_S -DCERT_CHAIN_PARA_HAS_EXTRA_FIELDS -D_SECURE_ATL -DCHROMIUM_BUILD -DU_STATIC_IMPLEMENTATION -DOS_WIN=1 -DWIN32 -D_WIN32 -D_WINDOWS -DWIN32_LEAN_AND_MEAN -DCOMPILER_MSVC -DWINAPI_NO_BUNDLED_LIBRARIES -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DSTATIC_EXPORTABLE_JS_API -I/builds/worker/checkouts/gecko/comm/mailnews/base/src -I/builds/worker/workspace/obj-build/comm/mailnews/base/src -I/builds/worker/checkouts/gecko/dom/base -I/builds/worker/checkouts/gecko/netwerk/base -I/builds/worker/workspace/obj-build/ipc/ipdl/_ipdlheaders -I/builds/worker/checkouts/gecko/ipc/chromium/src -I/builds/worker/checkouts/gecko/ipc/glue -I/builds/worker/workspace/obj-build/dist/include -I/builds/worker/workspace/obj-build/dist/include/nspr -I/builds/worker/workspace/obj-build/dist/include/nss -MD -FI /builds/worker/workspace/obj-build/mozilla-config.h -DMOZILLA_CLIENT -Qunused-arguments -Qunused-arguments -fcrash-diagnostics-dir=/builds/worker/artifacts -TP -Zc:sizedDealloc- -D_HAS_EXCEPTIONS=0 -W3 -Gy -Zc:inline -Gw -Wno-inline-new-delete -Wno-invalid-offsetof -Wno-microsoft-enum-value -Wno-microsoft-include -Wno-unknown-pragmas -Wno-ignored-pragmas -Wno-deprecated-declarations -Wno-invalid-noreturn -Wno-inconsistent-missing-override -Wno-implicit-exception-spec-mismatch -Wno-microsoft-exception-spec -Wno-unused-local-typedef -Wno-ignored-attributes -Wno-used-but-marked-unused -D_SILENCE_TR1_NAMESPACE_DEPRECATION_WARNING -GR- -Z7 -Xclang -load -Xclang /builds/worker/workspace/obj-build/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O2 -Oy- -Werror -Xclang -fexperimental-new-pass-manager  -Xclang -MP -Xclang -dependency-file -Xclang .deps/nsMessengerWinIntegration.obj.pp -Xclang -MT -Xclang nsMessengerWinIntegration.obj   /builds/worker/checkouts/gecko/comm/mailnews/base/src/nsMessengerWinIntegration.cpp
/builds/worker/checkouts/gecko/comm/mailnews/base/src/nsMessengerWinIntegration.cpp(1123,45): error: cast to smaller integer type 'unsigned short' from 'wchar_t *' [-Werror,-Wpointer-to-int-cast]

Which is part of the minimize to tray code...
https://searchfox.org/comm-central/source/mailnews/base/src/nsMessengerWinIntegration.cpp#1107-1123

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1661363 - Fix -Wpointer-to-int-cast warning. r?rjl

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/77f1985bf211
Fix -Wpointer-to-int-cast warning. r=rjl

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/42c1bdfcf3fc
followup - clang-format. rs=clang-format