1661374 - If "save to pdf" is selected printer, populate the system dialog with settings of last accepted printer

Status: VERIFIED FIXED

(Toolkit :: Printing, enhancement, P2)

Description

[Emma Malysz]

In Bug 1659626, we opted to hide the system dialog link if the selected printer was "Save to pdf" for Windows and Linux.

Jonathan had suggested that we should instead keep the link, and if the user clicks on the link with a save-to-pdf printer, we would just populate the system dialog with the settings of the last "normal" printer.

Comment 1

[Emma Malysz]

Attachment: Bug 1661374, save default printer name and allow user to open system dialog when saving to pdf is selected

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1ace9714b4f2
save default printer name and allow user to open system dialog when saving to pdf is selected r=jwatt,mstriemer

Comment 3

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/1ace9714b4f2

Comment 4

[Emma Malysz]

Comment on attachment 9172300 [details]
Bug 1661374, save default printer name and allow user to open system dialog when saving to pdf is selected

Beta/Release Uplift Approval Request

• User impact if declined: User won't be able to open the system dialog when "save to pdf" is selected printer
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce: 1. Open Firefox with print.tab_modal.enabled set to true

2. Print page
3. Switch to "save to pdf" printer
4. Notice "open system dialog" does not disappear
5. Click "open system dialog" link and notice the settings are populated with the default printer settings

On windows/Linux:

1. Ensure no printers are available (Save to pdf is only option)
2. Try printing
3. Notice "print using system dialog" link is hidden

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): No strings
• String changes made/needed: n/a

Comment 6

[Ryan VanderMeulen [:RyanVM]]

This has conflicts with at least bug 1661645. Not sure if you wanted to rebase around it or uplift that also?

Comment 7

[Blake Winton (:bwinton) (:☕️)]

(We want to uplift that too. I've pinged Mark.)

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9172300 [details]
Bug 1661374, save default printer name and allow user to open system dialog when saving to pdf is selected

Approved for 81.0b6.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/0fbf1718aae3

Comment 11

[Martin Balfanz [:mbalfanz]]

On OS X, I find this very confusing. I just ran into the situation where I applied some settings in the doorhanger (e.g. print backgrounds), then selected "print using system dialog" and my adjustments were gone. It's not obvious to the user why settings are set the way they are.

Is there a way we can respect (most) settings instead of using the ones of the last normal printer?

Comment 12

[Blake Winton (:bwinton) (:☕️)]

That makes sense to me. Since we're so late in the beta cycle already I've filed a new bug for v82, and we can figure out what to do and track the work over there.

Comment 13

[Emil Ghitta, QA [:emilghitta]]

This is verified fixed using Firefox 82.0a1 (BuildId:20200907094115) and Firefox 81.0b7 (BuildId:20200906164749) on Windows 10 64bit. macOS 10.14 & Ubuntu 18.04 64bit.