Closed Bug 1661457 Opened 3 months ago Closed 3 months ago

CompactPair should support in-place construction

Categories

(Core :: MFBT, task)

task

Tracking

()

RESOLVED FIXED
82 Branch
Tracking Status
firefox82 --- fixed

People

(Reporter: sg, Assigned: sg)

References

Details

Attachments

(1 file)

Types that are non-copyable/non-movable cannot be currently used with CompactPair, as its constructor move-constructs the elements. An in-place construction should be added. This may also be used in other contexts where move-construction would be expensive.

Pushed by sgiesecke@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/83f3f36d540f
Add in-place constructor to CompactPair. r=froydnj
Backout by rmaries@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/603459fd7f34
Backed out 5 changesets (bug 1661457, bug 1661428, bug 1661497, bug 1661502) for build bustages on Result.h. CLOSED TREE
Pushed by sgiesecke@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9bee16083767
Add in-place constructor to CompactPair. r=froydnj
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch
You need to log in before you can comment on or make changes to this bug.