1661473 - Regression in the CFR doorhanger layout

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, defect)

Description

[Andrei Oprea [:andreio]]

Attachment: image(4).png

STR:

1. Enable browser.newtabpage.activity-stream.asrouter.devtoolsEnabled
2. Navigate to about:newtab#asrouter
3. Find in page for FACEBOOK_CONTAINER_3_72
4. Click show and expand the notification that shows up in the address bar

Expected:
Preview image and text should be properly aligned
"Facebook Containers" and "by Mozilla" should not have a gap in between. Image should be aligned with the two strings

Design reference:
https://mozilla.invisionapp.com/share/YWLSGDZGUSF#/screens/316869059

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1643187

Comment 2

[Julien Cristau [:jcristau]]

Steven can you set a severity here?

Comment 3

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Bug 1661473 - Hide popup notification hint text element when empty. r=andreio!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dc90a7a18c07
Hide popup notification hint text element when empty. r=andreio

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/dc90a7a18c07

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Did you want to nominate this for Beta approval?

Comment 7

[(inactive) Nihanth Subramanya [:nhnt11]]

Comment on attachment 9174394 [details]
Bug 1661473 - Hide popup notification hint text element when empty. r=andreio!

Beta/Release Uplift Approval Request

• User impact if declined: Small visual discrepancy (extra whitespace)
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Just a simple whitespace-hiding css patch :)
• String changes made/needed:

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9174394 [details]
Bug 1661473 - Hide popup notification hint text element when empty. r=andreio!

Approved for 81.0rc1.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/992ae7a5ebe0