1661488 - The "Set as Default" sting is barely visible when the button is hovered on Linux using light OS themes

Status: VERIFIED FIXED

(Toolkit :: Themes, defect)

Description

[Ciprian Muresan [:cmuresan], Formerly of Ecosystem QA - please needinfo @mcoman for things regarding the team]

Attachment: image_2020_08_27T14_10_40_453Z.png

[Affected versions]:

• Firefox Nightly 82.0a1, BuildID 20200826214121
• Firefox Beta 81.0b1 BuildID 20200825191644

[Affected Platforms]:

• Ubuntu 18.04
• Ubuntu 20.04
• Linux MX 4.19

[Prerequisites]:

• Have no Browser set as Default or have a different browser set as the default.
• Have the system theme set to a Light theme.

[Steps to reproduce]:

1. Open the Firefox browser with a clean new profile.
2. Open a New Tab and hover the "Set as Default" button.
3. Observe the string color inside the button.

[Expected results]:

• The string is colored white while the button is hovered.

[Actual results]:

• The string is colored with a dark color while the button is hovered.

[Notes]:

• The string is barely legible while this effect takes place.
• The issue is reproducible on all default themes as long as the OS theme is Light.
• The issue is not reproducible if the System theme is set to a Dark one (eg. Adwaita-dark, Arc-dark)
• Attached a screenshot of the issue.

Comment 1

[Tim Nguyen :ntim]

Attachment: Bug 1661488 - Override button.css hover/active text color on .notification-button. r=dao,jaws

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dfbf65fb6736
Override button.css hover/active text color on .notification-button. r=jaws

Comment 3

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/dfbf65fb6736

Comment 4

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest Firefox Nightly (81.0a1 Build ID - 20200824094458) installed, on Windows 10 x64, Ubuntu 18.04 x64 and Mac 10.15. Now, I can confirm that the "Set as Default" string is visible when the button is hovered.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:ntim, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 6

[Tim Nguyen :ntim]

Comment on attachment 9172552 [details]
Bug 1661488 - Override button.css hover/active text color on .notification-button. r=dao,jaws

Beta/Release Uplift Approval Request

• User impact if declined: Unreadable text on notification button
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small verified change
• String changes made/needed: None

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9172552 [details]
Bug 1661488 - Override button.css hover/active text color on .notification-button. r=dao,jaws

Approved for 81.0b7.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/5d1e02739ec4

Comment 9

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest Firefox Beta (81.0b7 Build ID - 20200906164749) installed, on Windows 10 x64, Ubuntu 18.04 x64, and Mac 10.15. Now, I can confirm that the "Set as Default" string is visible when the button is hovered.