Closed Bug 1661509 Opened 3 years ago Closed 3 years ago

Left and right arrow navigation still doesn't work on photo grid demo at codinginparadise.org

Categories

(Core :: SVG, defect)

Product:
Core
Component:
SVG
Version:
20 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
82 Branch
Tracking Flags:
Tracking Status
firefox-esr68 --- wontfix
firefox-esr78 --- wontfix
firefox79 --- wontfix
firefox80 --- wontfix
firefox81 --- wontfix
firefox82 --- verified

People

(Reporter: dholbert, Assigned: emilio)

References

(Regression,
URL
)

Details

(Keywords: regression, testcase)

Attachments

(1 file)

Bug 1661509 - Fix SVGSVGElement::QueryInterface. r=longsonr
47 bytes, text/x-phabricator-request
Details | Review

+++ This bug was initially created as a clone of Bug #1459905 +++
[Spinning this off of Bug 1459905, which had a reduced testcase & a patch land to address that testcase, but apparently the original STR/URL is still broken.]

[Steps to reproduce]:

  1. Launch Firefox.
  2. Visit http://codinginparadise.org/projects/svgweb/samples/demo.html?name=photos&svg.render.forceflash=false
  3. Click on the left "<" and right buttons ">", below the "Show Demos Known to Fail" text.

[Expected result]:

  • The photo is moved accordingly.

[Actual result]:

  • Nothing happens when clicking on the right and left buttons.
Summary: Left and right arrow navigation doesn't work if the SVG is rendered with browser native svg → Left and right arrow navigation still doesn't work on photo grid demo at codinginparadise.org

Actually, the "up" and "down" buttons (^/v) on this site also seem to have no effect in current Nightly, too (whereas those ones were fine in Nightly 2020-08-25).

That feels unexpected, and it could indicate that bug 1459905's patch somehow took us a step away from correctness (at least as far as this demo is concerned).

Robert, perhaps you could take a look / do you know why the behavior might've changed in this way?

Flags: needinfo?(longsonr)

If you zoom first then everything suddenly starts to work so I really don't know what's going on with the site.

Flags: needinfo?(longsonr)

We're not reacting properly to the dynamic change of currentTranslate. But the change is reflected in the JS objects.

I can poke.

Assignee: nobody → emilio

Thanks for looking into this Emilio.

Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a955374449f8
Fix SVGSVGElement::QueryInterface. r=longsonr

https://hg.mozilla.org/mozilla-central/rev/a955374449f8

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox82: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch

Hi guys,

So I checked this bug on Windows 10 on Nightly 82.0a1 (2020-08-31) (64-bit) and it's been fixed.

Regards, Flor.

Status: RESOLVED → VERIFIED
status-firefox82: fixed → verified
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.