1661509 - Left and right arrow navigation still doesn't work on photo grid demo at codinginparadise.org

Status: VERIFIED FIXED

(Core :: SVG, defect)

Description

[Daniel Holbert [:dholbert]]

+++ This bug was initially created as a clone of Bug #1459905 +++
[Spinning this off of Bug 1459905, which had a reduced testcase & a patch land to address that testcase, but apparently the original STR/URL is still broken.]

[Steps to reproduce]:

1. Launch Firefox.
2. Visit http://codinginparadise.org/projects/svgweb/samples/demo.html?name=photos&svg.render.forceflash=false
3. Click on the left "<" and right buttons ">", below the "Show Demos Known to Fail" text.

[Expected result]:

• The photo is moved accordingly.

[Actual result]:

• Nothing happens when clicking on the right and left buttons.

Comment 1

[Daniel Holbert [:dholbert]]

Actually, the "up" and "down" buttons (^/v) on this site also seem to have no effect in current Nightly, too (whereas those ones were fine in Nightly 2020-08-25).

That feels unexpected, and it could indicate that bug 1459905's patch somehow took us a step away from correctness (at least as far as this demo is concerned).

Robert, perhaps you could take a look / do you know why the behavior might've changed in this way?

Comment 2

[Robert Longson [:longsonr]]

If you zoom first then everything suddenly starts to work so I really don't know what's going on with the site.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

We're not reacting properly to the dynamic change of currentTranslate. But the change is reflected in the JS objects.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

I can poke.

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1661509 - Fix SVGSVGElement::QueryInterface. r=longsonr

Comment 6

[Robert Longson [:longsonr]]

Thanks for looking into this Emilio.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a955374449f8
Fix SVGSVGElement::QueryInterface. r=longsonr

Comment 8

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/a955374449f8

Comment 9

[Florencia Di Ciocco, NI to vbalducci]

Hi guys,

So I checked this bug on Windows 10 on Nightly 82.0a1 (2020-08-31) (64-bit) and it's been fixed.

Regards, Flor.