Closed Bug 1661534 Opened 4 years ago Closed 4 years ago

Extension page: "Clear Cookies and Site Data" does nothing

Categories

(Toolkit :: Data Sanitization, defect, P2)

Firefox 82
defect

Tracking

()

RESOLVED FIXED
89 Branch
Tracking Status
firefox80 --- wontfix
firefox81 --- wontfix
firefox82 --- wontfix
firefox89 --- fixed

People

(Reporter: clessili, Assigned: liz, Mentored)

References

Details

Attachments

(3 files)

Attached image page info panel

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:82.0) Gecko/20100101 Firefox/82.0

Steps to reproduce:

Open an extension's page, like uBlock's settings, or a custom new tab.
Click on the page info button on the url bar, the one with a puzzle piece.
Click "Clear Cookies and Site Data...".

Actual results:

The panel closes.

Expected results:

Don't let people think they deleted the extension's settings. Either don't show the button, or show a prompt to confirm.

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Component: Untriaged → Preferences
See Also: → 1658229
Type: enhancement → defect
Component: Preferences → General
Product: Firefox → WebExtensions

Hello,

I’ve managed to reproduce the issue based on the provided STR, on the latest Nightly (82.0a1/20200902215721), Beta (81.0b5/20200901203141) and Release (80.0.1/20200831163820) under Windows 10 Pro 64-bit and Ubuntu 16.04 LTS.

Clicking the "Clear Cookies and Site Data…" button does indeed do nothing else but close the panel.

I’ve also attempted to search for a regression window spanning from 2019-09-01 (roughly when the "Clear Cookies and Site Data…" button seems to have been implemented) until the present day. All tested builds in the mentioned time frame are affected by the issue, thus the issue might not be a regression, but how it always has been.

Status: UNCONFIRMED → NEW
Has STR: --- → yes
Ever confirmed: true

Firefox should not provide any user ui to remove data/storage for extensions.

Product: WebExtensions → Firefox
Component: General → Data Sanitization
Product: Firefox → Toolkit

I agree!

Severity: -- → S3
Priority: -- → P2
Mentor: jhofmann
Assignee: nobody → liz
Status: NEW → ASSIGNED

Tried to replicate bug (on Firefox Nightly just built, on MacOS Mojave, version 10.14.6), got a confirmation dialog "Removing Cookies and Site Data" showing empty list of affected websites

(In reply to Liz Krane from comment #5)

Tried to replicate bug (on Firefox Nightly just built, on MacOS Mojave, version 10.14.6), got a confirmation dialog "Removing Cookies and Site Data" showing empty list of affected websites

See https://bugzilla.mozilla.org/show_bug.cgi?id=1661534#c3. Can we hide the "Clear Cookies and Site Data..." button in this case? :)

(In reply to :prathiksha from comment #6)

See https://bugzilla.mozilla.org/show_bug.cgi?id=1661534#c3. Can we hide the "Clear Cookies and Site Data..." button in this case? :)

Thanks for clarifying, Prathiksha! I didn't realize the image attachment posted its own comment, haha, so I was about to post a couple questions. Thanks for answering my main question in advance! :)

I do have one additional question still -- I didn't understand what clessili meant by opening "a custom new tab" for replicating this bug. What does that mean / could you provide steps for replicating the bug in this other scenario? (Meanwhile though, I'll look into how to check if we're viewing an extensions settings page.)

Thanks for all your help! I'm excited to get to contributing a small improvement to Firefox!

(In reply to Liz Krane from comment #7)

I do have one additional question still -- I didn't understand what clessili meant by opening "a custom new tab" for replicating this bug. What does that mean / could you provide steps for replicating the bug in this other scenario? (Meanwhile though, I'll look into how to check if we're viewing an extensions settings page.)

Good question. I'm not sure. You can ask clessili what they meant by that. OTOH if you've figured out a way to open a moz-extension page and reproduce the bug, I wouldn't worry about it.

Hello, by "custom new tab" I meant an extension that replaces the homepage, like Tabliss for example.

Attachment #9214259 - Attachment description: Bug 1661534 - Extension page: "Clear Cookies and Site Data" does nothing r=prathiksha → Bug 1661534 - Remove the "Clear Cookies and Site Data" button in the site identity panel for moz-extension pages. r=prathiksha
Pushed by prathikshaprasadsuman@gmail.com: https://hg.mozilla.org/integration/autoland/rev/baecf7eb6dfa Remove the "Clear Cookies and Site Data" button in the site identity panel for moz-extension pages. r=prathiksha
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: