1661573 - Only add [Fission] to bug titles for crash signatures that have >50% Fission (or move "Fission" from bug title to description)

Status: RESOLVED FIXED

(Socorro :: Webapp, task, P2)

Description

[Chris Peterson [:cpeterson]]

Adding [Fission] to the title of bugs filed for crash reports that have the DOMFissionEnabled flag might be too eager. Most crashes hit by Fission users will probably be unrelated to Fission.

The topcrashers page shows the Fission icon only if >50% of a signature's crash reports have DOMFissionEnabled. Can we use that same >50% logic when filing a new bug from a crash report page?

If the crash report page doesn't have access to how many of the other reports for this signature also has DOMFissionEnabled, then mentioning Fission in the bug's description field (instead of the bug title) would still be useful. Crash triagers will still see the comment in crash bugs possibly related to Fission without the Fission team have to triage every incoming crash that just happened to affect a Fission user. :)

Code for adding [Fission] to new bug's titles:

https://github.com/mozilla-services/socorro/blob/85f2201b998af930624dcf95891d20a7504e11fa/webapp-django/crashstats/crashstats/templatetags/jinja_helpers.py#L180-L192

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

The report view and signature report view have really different kinds of information which is why it's hard to add create-a-bug links to the signature report view and it's hard to reason about other crashes in the report view.

I can move it to the description field. I'll do that tomorrow.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 5533: bug 1661573: move Fission note to bug description

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

This changes the description from something like this:

Crash report: https://crash-stats.mozilla.org/report/index/7ab56f38-0387-4b09-bdcc-0dc8b0200827

Top 10 frames of crashing thread:

0 xul.dll static mozilla::layers::ContainerLayerMLGPU::FindVisibleBounds gfx/layers/mlgpu/ContainerLayerMLGPU.cpp:110
1 xul.dll static mozilla::layers::ContainerLayerMLGPU::FindVisibleBounds gfx/layers/mlgpu/ContainerLayerMLGPU.cpp:132
2 xul.dll static mozilla::layers::ContainerLayerMLGPU::FindVisibleBounds gfx/layers/mlgpu/ContainerLayerMLGPU.cpp:132
3 xul.dll static mozilla::layers::ContainerLayerMLGPU::FindVisibleBounds gfx/layers/mlgpu/ContainerLayerMLGPU.cpp:132
4 xul.dll mozilla::layers::ContainerLayerMLGPU::ComputeIntermediateSurfaceBounds gfx/layers/mlgpu/ContainerLayerMLGPU.cpp:162
5 xul.dll mozilla::layers::FrameBuilder::Build gfx/layers/mlgpu/FrameBuilder.cpp:69
6 xul.dll mozilla::layers::LayerManagerMLGPU::RenderLayers gfx/layers/mlgpu/LayerManagerMLGPU.cpp:377
7 xul.dll mozilla::layers::LayerManagerMLGPU::Composite gfx/layers/mlgpu/LayerManagerMLGPU.cpp:331
8 xul.dll mozilla::layers::LayerManagerMLGPU::EndTransaction gfx/layers/mlgpu/LayerManagerMLGPU.cpp:280
9 xul.dll mozilla::layers::CompositorBridgeParent::CompositeToTarget gfx/layers/ipc/CompositorBridgeParent.cpp:1034

To something like this:

Maybe Fission related.

Crash report: https://crash-stats.mozilla.org/report/index/7ab56f38-0387-4b09-bdcc-0dc8b0200827

Top 10 frames of crashing thread:

0 xul.dll static mozilla::layers::ContainerLayerMLGPU::FindVisibleBounds gfx/layers/mlgpu/ContainerLayerMLGPU.cpp:110
1 xul.dll static mozilla::layers::ContainerLayerMLGPU::FindVisibleBounds gfx/layers/mlgpu/ContainerLayerMLGPU.cpp:132
2 xul.dll static mozilla::layers::ContainerLayerMLGPU::FindVisibleBounds gfx/layers/mlgpu/ContainerLayerMLGPU.cpp:132
3 xul.dll static mozilla::layers::ContainerLayerMLGPU::FindVisibleBounds gfx/layers/mlgpu/ContainerLayerMLGPU.cpp:132
4 xul.dll mozilla::layers::ContainerLayerMLGPU::ComputeIntermediateSurfaceBounds gfx/layers/mlgpu/ContainerLayerMLGPU.cpp:162
5 xul.dll mozilla::layers::FrameBuilder::Build gfx/layers/mlgpu/FrameBuilder.cpp:69
6 xul.dll mozilla::layers::LayerManagerMLGPU::RenderLayers gfx/layers/mlgpu/LayerManagerMLGPU.cpp:377
7 xul.dll mozilla::layers::LayerManagerMLGPU::Composite gfx/layers/mlgpu/LayerManagerMLGPU.cpp:331
8 xul.dll mozilla::layers::LayerManagerMLGPU::EndTransaction gfx/layers/mlgpu/LayerManagerMLGPU.cpp:280
9 xul.dll mozilla::layers::CompositorBridgeParent::CompositeToTarget gfx/layers/ipc/CompositorBridgeParent.cpp:1034

If it's at the bottom of the description, then it could get truncated. If it's at the top, I figure it's easier for people to see.

Chris: Does that look ok?

Comment 4

[Chris Peterson [:cpeterson]]

(In reply to Will Kahn-Greene [:willkg] ET needinfo? me from comment #3)

Maybe Fission related.

...

If it's at the bottom of the description, then it could get truncated. If it's at the top, I figure it's easier for people to see.

Chris: Does that look ok?

LGTM!

Perhaps the Fission comment should mention that we suspect it might be Fission related because the crash report has the DOMFissionEnabled flag? Otherwise, someone reading the bug might not know why it mentions Fission.

Comment 5

[Will Kahn-Greene [:willkg] ET needinfo? me]

I'll change it so it adds:

Maybe Fission related. (DOMFissionEnabled=1)

Comment 6

[Will Kahn-Greene [:willkg] ET needinfo? me]

willkg merged PR #5533: "bug 1661573: move Fission note to bug description" in ed3d4be.

Comment 7

[Will Kahn-Greene [:willkg] ET needinfo? me]

This deployed in bug #1662207 just now. Marking as FIXED.