Closed
Bug 1661659
Opened 4 years ago
Closed 4 years ago
Decision tasks take well above 10 minutes after bug 1657769
Categories
(Firefox Build System :: Task Configuration, defect)
Firefox Build System
Task Configuration
Tracking
(firefox-esr68 unaffected, firefox-esr78 unaffected, firefox80 unaffected, firefox81 unaffected, firefox82 fixed)
RESOLVED
FIXED
82 Branch
| Tracking | Status | |
|---|---|---|
| firefox-esr68 | --- | unaffected |
| firefox-esr78 | --- | unaffected |
| firefox80 | --- | unaffected |
| firefox81 | --- | unaffected |
| firefox82 | --- | fixed |
People
(Reporter: glandium, Assigned: glandium)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
No description provided.
|
Assignee | |
Comment 1•4 years ago
|
||
Using nested Any generates deeply nested non-trivial schemas because we
also end up nesting optionally_keyed_by's, and the addition of one field
in one optionally_keyed_by in bug 1657769 made the whole schema
compilation step an order of magnitude slower.
Even before bug 1657769, the schema compilation step was slow for tests,
and with this change, it's virtually instantaneous.
|
|
Assignee | |
Comment 2•4 years ago
•
|
||
With this patch, I got a decision task on try in 3:30, 23s of which are mercurial. That is at least 1 minute faster than it was before bug 1657769.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4215f7cbd09e1f5a66481ce74e4768c333bea233&selectedTaskRun=GYQk_spkSiylrzivWrHg4g.0
|
||
Updated•4 years ago
|
Keywords: regression
|
|
||
Comment 3•4 years ago
|
||
Set release status flags based on info from the regressing bug 1657769
status-firefox80:
--- → unaffected
status-firefox81:
--- → unaffected
status-firefox82:
--- → affected
status-firefox-esr68:
--- → unaffected
status-firefox-esr78:
--- → unaffected
Pushed by mh@glandium.org: https://hg.mozilla.org/integration/autoland/rev/11ff00d15299 Reimplement optionally_keyed_by as a validator function rather than in terms of nested Any. r=taskgraph-reviewers,ahal
|
||
Comment 5•4 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch
|
||
Updated•4 years ago
|
Has Regression Range: --- → yes
You need to log in
before you can comment on or make changes to this bug.
Description
•