166172 - dolog.pl sends bare LFs

Status: RESOLVED FIXED

(Webtools Graveyard :: Bonsai, defect)

Description

[Antony Mawer]

When setting up Bonsai using the Qmail MTA, any CVS checkins resulted in
dolog.pl failing when it attempted to send its checkin mail. Qmail rejects the
email due to receiving only LF characters as line endings from the dolog.pl
program. It directs the user to a page describing the problem (see URL).

The solution to this problem is to replace all \n characters with \r\n (ie. all
LFs with CRLF pairs). I'll affix a patch in a sec.

Comment 1

[Antony Mawer]

Attachment: replace occurances of \n with \r\n

Proposed fix (works for me!)

Comment 2

[Dave Miller [:justdave]]

assign to patch author

Comment 3

[Antony Mawer]

The attached patch has undoubtably bitrotted -- if I make an up-to-date patch is
someone willing to handle review and checkin? (I don't have cvs access)

Comment 4

[cls]

Attachment: use Mail::Mailer

We already depend upon Mail::Mailer for sending the hook mail so we might as
well use it for dolog.pl as well.  Mail::Mailer::smtp uses Net::SMTP which uses
Net::Cmd->datasend which automatically converts LF to CRLF.

Comment 5

[cls]

Patch has been checked in.